Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance zsh completion for the packer command #12356

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

mrolli
Copy link
Contributor

@mrolli mrolli commented Apr 8, 2023

Now completes more commands and also matches template files both for
*pkr.hcl and *pkr.json as suggested by the packer template naming scheme.

Now completes more commands and also matches template files both for
*pkr.hcl and *pkr.json as suggested by the packer template naming scheme.
@mrolli mrolli requested a review from a team as a code owner April 8, 2023 08:10
@hashicorp-cla
Copy link

hashicorp-cla commented Apr 8, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. Overall this looks good . I left one suggestion, which is not a blocker.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2023
@mrolli mrolli deleted the enhance-zsh-completion branch December 21, 2023 07:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.8.x Backport PR changes to `release/1.8.x`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants