Plugin latest unavailable checksum fail fix #12103
Merged
+58
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mockPluginGetter would always succeed in returning a file from the list of suggested releases, which does not let us test what happens when a release is not yet complete, and a checksum file fails to be fetched from the source. This commit changes this behaviour so that we get an error when a checksum does not exist, mirrorring what happens in real conditions.
JenGoldstrich
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
LGTM, I had some questions about this that I asked @lbajolet-hashicorp in slack
When Packer tries to get the latest version of a plugin, it will attempt to get the latest version from a list that is picked from the list of releases, fetched directly from Github. What may happen is that a release is triggered, the assets are not yet available, including the checksum file, which is uploaded last, at the end of the release process. This causes any client that tries to get the latest version of a plugin to fail during that window, as the code will fail immediately whenever a checksum file is unavailable. To circumvent this issue, and fallback to a previous version, we acknowledge that a checksum was unavailable then trying to get the latest version, and fallback to a previous one.
lbajolet-hashicorp
force-pushed
the
plugin_latest_unavailable_checksum_fail_fix
branch
from
87127f0 to
0900a54
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Packer tries to get the latest version of a plugin, it will attempt to get the latest version from a list that is picked from the list of releases, fetched directly from Github.
What may happen is that a release is triggered, the assets are not yet available, including the checksum file, which is uploaded last, at the end of the release process.
This causes any client that tries to get the latest version of a plugin to fail during that window, as the code will fail immediately whenever a checksum file is unavailable.
To circumvent this issue, and fallback to a previous version, we acknowledge that a checksum was unavailable then trying to get the latest version, and fallback to a previous one.
Closes #11897