Flight Icons Migration #20001
Flight Icons Migration #20001
Conversation
Ember Test Audit comparison
|
| @@ -31,7 +31,7 @@ | |||
| role="tooltip" | |||
| aria-label="Allocation was preempted" | |||
| > | |||
| {{x-icon "boot" class="is-faded"}} | |||
| <FlightIcon @name="boot" class="is-faded" /> | |||
There was a problem hiding this comment.
There is no boot flight icon.
Semantically, the boot here means "preempted" or "evicted" or "kicked out". Maybe there's an adequate Flight replacement.
There was a problem hiding this comment.
Going to use stop-circle for now until we get a SMB3 goomba boot icon
… scaling +/- buttons
| Copyright (c) HashiCorp, Inc. | ||
| SPDX-License-Identifier: BUSL-1.1 | ||
| ~}} | ||
|
|
There was a problem hiding this comment.
SVG code from the formerly-separate .svg file, now as a component. Used in our <LoadingSpinner /> component.
| } else if (this.status === 'initializing') { | ||
| return 'node-init-circle-fill'; | ||
| return 'entry-point'; |
There was a problem hiding this comment.
Using this for initializing nodes now:
| @@ -57,3 +57,33 @@ $icon-dimensions-large: 2rem; | |||
| color: $grey; | |||
| } | |||
| } | |||
|
|
|||
| // Flight Icons general override: notes: | |||
There was a problem hiding this comment.
I don't feel great about this but it seems necessary given Nomad's current status in a transitory period between a its historical UI design and a more Helios-centered one.
There was a problem hiding this comment.
agreed it's not ideal as we would prefer these class names to be more of a private API, however, you're not the first (and won't be the last) to hook into them for specific situations that arise in our products.
| @@ -11,7 +11,7 @@ | |||
| role="tooltip" | |||
| aria-label="Allocation depends on unhealthy drivers" | |||
| > | |||
| {{x-icon "alert-triangle" class="is-warning"}} | |||
| <FlightIcon @name="alert-triangle-fill" @color="#fa8e23" /> | |||
There was a problem hiding this comment.
General pattern: bulma classes to add colour vs expressly using the @color prop.
| @@ -40,7 +40,6 @@ | |||
| <TaskGroupRow | |||
| @data-test-task-group={{row.model.name}} | |||
| @taskGroup={{row.model}} | |||
| @onClick={{fn this.gotoTaskGroup row.model}} | |||
There was a problem hiding this comment.
Side-effect: noticed in testing that clicking the exact centre of task group row's scaling buttons would route you into that task group. Long-term this gets fixed by upgrading to Helios tables.
philrenaud
force-pushed
the
ui-icon-migration
branch
from
51ecaff
to
d8a1ba6
Compare
tgross
added
the
stage/needs-rebase
This is a start at migrating existing structure icons to FlightIcons. Some caveats that will need to be investigated further by someone more familiar with the codebase
x-iconinstances left that either take in arguments or didn't have a defined mapping to a new icon when we made the list 2+ years ago. These will need to be looked at on a case-by-case basis.x-iconstill needs to be done