chore: run tests in isolation #332
Merged
+459
−275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brkalow
changed the title
added 2 commits
January 18, 2023 18:42
added 2 commits
January 18, 2023 18:49
timneutkens
approved these changes
Jan 19, 2023
|
Looks good to me! |
brkalow
commented
Jan 19, 2023
| @@ -0,0 +1,32 @@ | |||
| --- | |||
| title: 'foo' | |||
| name: jeff | |||
Comment on lines
+99
to
+106
| fn({ | ||
| dir() { | ||
| return tmpDir | ||
| }, | ||
| browser() { | ||
| return browser | ||
| }, | ||
| }) |
thiskevinwang
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off of #331
Refactors integration tests to run against isolated fixtures. This is accomplished by copying the fixtures defined in
__tests__/fixturesinto tmp directories and doing a clean install of a locally packednext-mdx-remote, along withnext,react, andreact-dom. This ensures each test case is independently executed and by relying onnpm packwe are testing against the eventually published artifact.We now expose a
createDescribetest utility that handles creating an isolated directory from one of our fixtures:h/t to @timneutkens for pointing me at Next.js's testing approach, which this is inspired by 🙏