Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize on only two value dumping/diffing libraries #669

Merged
merged 1 commit into from
Mar 14, 2024

Commits on Mar 12, 2024

  1. Standardize on only two value dumping/diffing libraries

    Due to the quite messy heritage of this codebase -- including a large part
    of it being just a fork of my earlier personal project ZCL -- there were
    many different conventions for how to pretty-print and diff values in the
    tests in different parts of the codebase.
    
    To reduce the dependency sprawl, this commit now standardizes on:
      - github.com/davecgh/go-spew for pretty-printing
      - github.com/google/go-cmp for diffing
    
    These two dependencies were already present anyway, are the most general
    out of all of the candidates, and are also already in use by at least some
    of HCL's most significant callers, such as HashiCorp Terraform.
    
    The version of go-cmp we were previously using seems to have a bug that
    causes the tests to crash when run under the Go race detector, so I've
    also upgraded that dependency to latest here to clear that bug.
    apparentlymart committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    7499a3d View commit details
    Browse the repository at this point in the history