-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIX support and build tag fixes #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. While there's no difference between route_info_{aix,solaris}.go
, but I think that's fine. Duplicating a small bit of code seems like the right choice here over build tag wrestling.
Just need @jtroy to sign the CLA |
Now that you mention it, I'm happy to combine them into
Signed, thanks! |
Because there's no contract that says Solaris and AIX are going to remain compatible, it's fine that they were separate to begin with. Hypothetically, if (when?) these two platforms diverge and there is a bug that requires being addressed, there won't be any shuffling required to move the library bits around if we keep them separate to begin with. |
Thanks @schmichael, @sean-. What's the possibility of getting a release cut? I need to get hashicorp/vault updated as that's the next link in the dependency chain I'm trying to fix. |
Sure thing; done: https://github.com/hashicorp/go-sockaddr/releases/tag/v1.0.7 |
Thanks @schmichael! |
This PR is to bring #37 up to speed with master. Build tags were needed for the Solaris route info code so it wouldn't be built for GOOS=aix.
Additionally, I ran a
go build
against each GOOS target and found that Android is broken in master. I made the necessary tweaks to get the build to succeed, but I'm unable to test it. It's in this PR because it was adjacent to the work I was doing, but I can drop it or submit a second PR for it if desired.Thanks,
John