Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use base32 instead of base64 for identifiers #21

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Use base32 instead of base64 for identifiers #21

merged 3 commits into from
Mar 8, 2024

Commits on Mar 5, 2024

  1. Use base32 instead of base64 for identifiers 

    Base64 in Go 1.22 requires that the list of characters
in the encoding be unique. This is not possible
if we are using it to generate Go identifiers.

So, we switch to base32.

This is not a breaking change as this only affects
the generated code, and not the wire format.
    Christopher Swenson committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    ab68ae4 View commit details
    Browse the repository at this point in the history

  2. gofmt

    Christopher Swenson committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    cd6e539 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Test with codecgen

    Christopher Swenson committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    bd91d47 View commit details
    Browse the repository at this point in the history