Use base32 instead of base64 for identifiers #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 5, 2024 08:53
Base64 in Go 1.22 requires that the list of characters in the encoding be unique. This is not possible if we are using it to generate Go identifiers. So, we switch to base32. This is not a breaking change as this only affects the generated code, and not the wire format.
swenson
commented
Mar 8, 2024
| msgpack-rpc protocol defined at: | ||
| https://github.com/msgpack-rpc/msgpack-rpc/blob/master/spec.md | ||
|
|
||
| - For messagepack, configure how ambiguities in handling raw bytes are resolved |
There was a problem hiding this comment.
All this noise is from gofmt, unfortunately.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base64 in Go 1.22 requires that the list of characters in the encoding be unique. This is not possible
if we are using it to generate Go identifiers.
So, we switch to base32.
This is not a breaking change as this only affects the generated code, and not the wire format.