hclogvet: updates for go1.22 #138

shoenig · 2024-03-04T21:16:22Z

fixes panic due to go1.22 incompats

==> Linting hclog statements...
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x59351e]

goroutine 14 [running]:
go/types.(*Checker).handleBailout(0xc0004c9c00, 0xc0023f5c10)
        /opt/google/go/src/go/types/check.go:367 +0x88
panic({0x70ef40?, 0x991a80?})
        /opt/google/go/src/runtime/panic.go:770 +0x132
go/types.(*StdSizes).Sizeof(0x0, {0x7db790, 0x995620})
        /opt/google/go/src/go/types/sizes.go:228 +0x31e
go/types.(*Config).sizeof(...)
        /opt/google/go/src/go/types/sizes.go:333
go/types.representableConst.func1({0x7db790?, 0x995620?})
        /opt/google/go/src/go/types/const.go:76 +0x9e
go/types.representableConst({0x7dccc8, 0x98a388}, 0xc0004c9c00, 0x995620, 0xc0023f1c88)
        /opt/google/go/src/go/types/const.go:92 +0x192

tgross

LGTM 👍

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/hashicorp/go-hclog](https://togithub.com/hashicorp/go-hclog) | `v1.6.2` -> `v1.6.3` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fhashicorp%2fgo-hclog/v1.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fhashicorp%2fgo-hclog/v1.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fhashicorp%2fgo-hclog/v1.6.2/v1.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fhashicorp%2fgo-hclog/v1.6.2/v1.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>hashicorp/go-hclog (github.com/hashicorp/go-hclog)</summary> ### [`v1.6.3`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.3): Optional JSON escaping [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.6.2...v1.6.3) #### What's Changed - hclogvet: updates for go1.22 by [@shoenig](https://togithub.com/shoenig) in [hashicorp/go-hclog#138 - support configure json escape when log in json format by [@Ericwww](https://togithub.com/Ericwww) in [hashicorp/go-hclog#141 #### New Contributors - [@Ericwww](https://togithub.com/Ericwww) made their first contribution in [hashicorp/go-hclog#141 **Full Changelog**: hashicorp/go-hclog@v1.6.2...v1.6.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/hetznercloud/terraform-provider-hcloud).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/hashicorp/go-hclog](https://togithub.com/hashicorp/go-hclog) | `v1.6.2` -> `v1.6.3` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fhashicorp%2fgo-hclog/v1.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fhashicorp%2fgo-hclog/v1.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fhashicorp%2fgo-hclog/v1.6.2/v1.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fhashicorp%2fgo-hclog/v1.6.2/v1.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>hashicorp/go-hclog (github.com/hashicorp/go-hclog)</summary> ### [`v1.6.3`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.3): Optional JSON escaping [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.6.2...v1.6.3) #### What's Changed - hclogvet: updates for go1.22 by [@shoenig](https://togithub.com/shoenig) in [hashicorp/go-hclog#138 - support configure json escape when log in json format by [@Ericwww](https://togithub.com/Ericwww) in [hashicorp/go-hclog#141 #### New Contributors - [@Ericwww](https://togithub.com/Ericwww) made their first contribution in [hashicorp/go-hclog#141 **Full Changelog**: hashicorp/go-hclog@v1.6.2...v1.6.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/hashicorp/go-hclog](https://togithub.com/hashicorp/go-hclog) | `v1.6.2` -> `v1.6.3` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fhashicorp%2fgo-hclog/v1.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fhashicorp%2fgo-hclog/v1.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fhashicorp%2fgo-hclog/v1.6.2/v1.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fhashicorp%2fgo-hclog/v1.6.2/v1.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>hashicorp/go-hclog (github.com/hashicorp/go-hclog)</summary> ### [`v1.6.3`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.3): Optional JSON escaping [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.6.2...v1.6.3) #### What's Changed - hclogvet: updates for go1.22 by [@shoenig](https://togithub.com/shoenig) in [hashicorp/go-hclog#138 - support configure json escape when log in json format by [@Ericwww](https://togithub.com/Ericwww) in [hashicorp/go-hclog#141 #### New Contributors - [@Ericwww](https://togithub.com/Ericwww) made their first contribution in [hashicorp/go-hclog#141 **Full Changelog**: hashicorp/go-hclog@v1.6.2...v1.6.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/rgst-io/stencil).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…n-telemetry#32090) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/hashicorp/go-hclog](https://togithub.com/hashicorp/go-hclog) | `v1.6.2` -> `v1.6.3` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fhashicorp%2fgo-hclog/v1.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fhashicorp%2fgo-hclog/v1.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fhashicorp%2fgo-hclog/v1.6.2/v1.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fhashicorp%2fgo-hclog/v1.6.2/v1.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>hashicorp/go-hclog (github.com/hashicorp/go-hclog)</summary> ### [`v1.6.3`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.3): Optional JSON escaping [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.6.2...v1.6.3) #### What's Changed - hclogvet: updates for go1.22 by [@&open-telemetry#8203;shoenig](https://togithub.com/shoenig) in [hashicorp/go-hclog#138 - support configure json escape when log in json format by [@&open-telemetry#8203;Ericwww](https://togithub.com/Ericwww) in [hashicorp/go-hclog#141 #### New Contributors - [@&open-telemetry#8203;Ericwww](https://togithub.com/Ericwww) made their first contribution in [hashicorp/go-hclog#141 **Full Changelog**: hashicorp/go-hclog@v1.6.2...v1.6.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>

hclogvet: updates for go1.22

1f0704a

shoenig requested a review from tgross March 4, 2024 21:16

tgross approved these changes Mar 4, 2024

View reviewed changes

shoenig merged commit 5dbb615 into main Mar 4, 2024
19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hclogvet: updates for go1.22 #138

hclogvet: updates for go1.22 #138

shoenig commented Mar 4, 2024 •

edited

tgross left a comment

hclogvet: updates for go1.22 #138

hclogvet: updates for go1.22 #138

Conversation

shoenig commented Mar 4, 2024 • edited

tgross left a comment

Choose a reason for hiding this comment

shoenig commented Mar 4, 2024 •

edited