Fix colors not being forced on correctly. #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go test -v -run TestLogger/colorize
Turns out that the color package we use was doing it's own "should colors be on or not" detection, which interferred with our own detection. This caused situations where colors were forced on to still be off (and, maddeningly, would show up in weird contexts because it dependent on Stdout being not a terminal to break when forced).
jooola
pushed a commit
to hetznercloud/terraform-provider-hcloud
that referenced
this pull request
Dec 12, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/hashicorp/go-hclog](https://togithub.com/hashicorp/go-hclog) | require | minor | `v1.5.0` -> `v1.6.1` | --- ### Release Notes <details> <summary>hashicorp/go-hclog (github.com/hashicorp/go-hclog)</summary> ### [`v1.6.1`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.1): Fix forcing color [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.6.0...v1.6.1) #### What's Changed - Fix colors not being forced on correctly. by [@​evanphx](https://togithub.com/evanphx) in [hashicorp/go-hclog#136 **Full Changelog**: hashicorp/go-hclog@v1.6.0...v1.6.1 ### [`v1.6.0`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.0): New level inheritance mode [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.5.0...v1.6.0) This release adds the ability to have sub-loggers arrange themselves into a tree and sync the level changes downward in the tree. #### What's Changed - SEC-090: Automated trusted workflow pinning (2023-04-03) by [@​hashicorp-tsccr](https://togithub.com/hashicorp-tsccr) in [hashicorp/go-hclog#128 - Docs: InferLevelsWithTimestamp relies on InferLevels being true by [@​peteski22](https://togithub.com/peteski22) in [hashicorp/go-hclog#135 - Implement the ability to more logically share level hierarchies by [@​evanphx](https://togithub.com/evanphx) in [hashicorp/go-hclog#134 #### New Contributors - [@​hashicorp-tsccr](https://togithub.com/hashicorp-tsccr) made their first contribution in [hashicorp/go-hclog#128 - [@​peteski22](https://togithub.com/peteski22) made their first contribution in [hashicorp/go-hclog#135 **Full Changelog**: hashicorp/go-hclog@v1.5.0...v1.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/hetznercloud/terraform-provider-hcloud). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
codeboten
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Dec 14, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/hashicorp/go-hclog](https://togithub.com/hashicorp/go-hclog) | require | minor | `v1.5.0` -> `v1.6.2` | --- ### Release Notes <details> <summary>hashicorp/go-hclog (github.com/hashicorp/go-hclog)</summary> ### [`v1.6.2`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.2): Fix level syncing [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.6.1...v1.6.2) #### What's Changed - Conside if the level is to be used separately from if the levels should be calculated by [@​evanphx](https://togithub.com/evanphx) in [hashicorp/go-hclog#137 **Full Changelog**: hashicorp/go-hclog@v1.6.1...v1.6.2 ### [`v1.6.1`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.1): Fix forcing color [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.6.0...v1.6.1) #### What's Changed - Fix colors not being forced on correctly. by [@​evanphx](https://togithub.com/evanphx) in [hashicorp/go-hclog#136 **Full Changelog**: hashicorp/go-hclog@v1.6.0...v1.6.1 ### [`v1.6.0`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.0): New level inheritance mode [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.5.0...v1.6.0) This release adds the ability to have sub-loggers arrange themselves into a tree and sync the level changes downward in the tree. #### What's Changed - SEC-090: Automated trusted workflow pinning (2023-04-03) by [@​hashicorp-tsccr](https://togithub.com/hashicorp-tsccr) in [hashicorp/go-hclog#128 - Docs: InferLevelsWithTimestamp relies on InferLevels being true by [@​peteski22](https://togithub.com/peteski22) in [hashicorp/go-hclog#135 - Implement the ability to more logically share level hierarchies by [@​evanphx](https://togithub.com/evanphx) in [hashicorp/go-hclog#134 #### New Contributors - [@​hashicorp-tsccr](https://togithub.com/hashicorp-tsccr) made their first contribution in [hashicorp/go-hclog#128 - [@​peteski22](https://togithub.com/peteski22) made their first contribution in [hashicorp/go-hclog#135 **Full Changelog**: hashicorp/go-hclog@v1.5.0...v1.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
haraldh
pushed a commit
to matter-labs/vault-auth-tee
that referenced
this pull request
Dec 21, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/hashicorp/go-hclog](https://togithub.com/hashicorp/go-hclog) | require | minor | `v1.5.0` -> `v1.6.2` | --- ### Release Notes <details> <summary>hashicorp/go-hclog (github.com/hashicorp/go-hclog)</summary> ### [`v1.6.2`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.2): Fix level syncing [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.6.1...v1.6.2) #### What's Changed - Conside if the level is to be used separately from if the levels should be calculated by [@​evanphx](https://togithub.com/evanphx) in [hashicorp/go-hclog#137 **Full Changelog**: hashicorp/go-hclog@v1.6.1...v1.6.2 ### [`v1.6.1`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.1): Fix forcing color [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.6.0...v1.6.1) #### What's Changed - Fix colors not being forced on correctly. by [@​evanphx](https://togithub.com/evanphx) in [hashicorp/go-hclog#136 **Full Changelog**: hashicorp/go-hclog@v1.6.0...v1.6.1 ### [`v1.6.0`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.0): New level inheritance mode [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.5.0...v1.6.0) This release adds the ability to have sub-loggers arrange themselves into a tree and sync the level changes downward in the tree. #### What's Changed - SEC-090: Automated trusted workflow pinning (2023-04-03) by [@​hashicorp-tsccr](https://togithub.com/hashicorp-tsccr) in [hashicorp/go-hclog#128 - Docs: InferLevelsWithTimestamp relies on InferLevels being true by [@​peteski22](https://togithub.com/peteski22) in [hashicorp/go-hclog#135 - Implement the ability to more logically share level hierarchies by [@​evanphx](https://togithub.com/evanphx) in [hashicorp/go-hclog#134 #### New Contributors - [@​hashicorp-tsccr](https://togithub.com/hashicorp-tsccr) made their first contribution in [hashicorp/go-hclog#128 - [@​peteski22](https://togithub.com/peteski22) made their first contribution in [hashicorp/go-hclog#135 **Full Changelog**: hashicorp/go-hclog@v1.5.0...v1.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/matter-labs/vault-auth-tee). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
nslaughter
pushed a commit
to nslaughter/opentelemetry-collector-contrib
that referenced
this pull request
Dec 27, 2023
…#29814) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/hashicorp/go-hclog](https://togithub.com/hashicorp/go-hclog) | require | minor | `v1.5.0` -> `v1.6.2` | --- ### Release Notes <details> <summary>hashicorp/go-hclog (github.com/hashicorp/go-hclog)</summary> ### [`v1.6.2`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.2): Fix level syncing [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.6.1...v1.6.2) #### What's Changed - Conside if the level is to be used separately from if the levels should be calculated by [@&open-telemetry#8203;evanphx](https://togithub.com/evanphx) in [hashicorp/go-hclog#137 **Full Changelog**: hashicorp/go-hclog@v1.6.1...v1.6.2 ### [`v1.6.1`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.1): Fix forcing color [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.6.0...v1.6.1) #### What's Changed - Fix colors not being forced on correctly. by [@&open-telemetry#8203;evanphx](https://togithub.com/evanphx) in [hashicorp/go-hclog#136 **Full Changelog**: hashicorp/go-hclog@v1.6.0...v1.6.1 ### [`v1.6.0`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.0): New level inheritance mode [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.5.0...v1.6.0) This release adds the ability to have sub-loggers arrange themselves into a tree and sync the level changes downward in the tree. #### What's Changed - SEC-090: Automated trusted workflow pinning (2023-04-03) by [@&open-telemetry#8203;hashicorp-tsccr](https://togithub.com/hashicorp-tsccr) in [hashicorp/go-hclog#128 - Docs: InferLevelsWithTimestamp relies on InferLevels being true by [@&open-telemetry#8203;peteski22](https://togithub.com/peteski22) in [hashicorp/go-hclog#135 - Implement the ability to more logically share level hierarchies by [@&open-telemetry#8203;evanphx](https://togithub.com/evanphx) in [hashicorp/go-hclog#134 #### New Contributors - [@&open-telemetry#8203;hashicorp-tsccr](https://togithub.com/hashicorp-tsccr) made their first contribution in [hashicorp/go-hclog#128 - [@&open-telemetry#8203;peteski22](https://togithub.com/peteski22) made their first contribution in [hashicorp/go-hclog#135 **Full Changelog**: hashicorp/go-hclog@v1.5.0...v1.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
nslaughter
pushed a commit
to nslaughter/opentelemetry-collector-contrib
that referenced
this pull request
Dec 27, 2023
…#29814) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/hashicorp/go-hclog](https://togithub.com/hashicorp/go-hclog) | require | minor | `v1.5.0` -> `v1.6.2` | --- ### Release Notes <details> <summary>hashicorp/go-hclog (github.com/hashicorp/go-hclog)</summary> ### [`v1.6.2`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.2): Fix level syncing [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.6.1...v1.6.2) #### What's Changed - Conside if the level is to be used separately from if the levels should be calculated by [@&open-telemetry#8203;evanphx](https://togithub.com/evanphx) in [hashicorp/go-hclog#137 **Full Changelog**: hashicorp/go-hclog@v1.6.1...v1.6.2 ### [`v1.6.1`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.1): Fix forcing color [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.6.0...v1.6.1) #### What's Changed - Fix colors not being forced on correctly. by [@&open-telemetry#8203;evanphx](https://togithub.com/evanphx) in [hashicorp/go-hclog#136 **Full Changelog**: hashicorp/go-hclog@v1.6.0...v1.6.1 ### [`v1.6.0`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.0): New level inheritance mode [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.5.0...v1.6.0) This release adds the ability to have sub-loggers arrange themselves into a tree and sync the level changes downward in the tree. #### What's Changed - SEC-090: Automated trusted workflow pinning (2023-04-03) by [@&open-telemetry#8203;hashicorp-tsccr](https://togithub.com/hashicorp-tsccr) in [hashicorp/go-hclog#128 - Docs: InferLevelsWithTimestamp relies on InferLevels being true by [@&open-telemetry#8203;peteski22](https://togithub.com/peteski22) in [hashicorp/go-hclog#135 - Implement the ability to more logically share level hierarchies by [@&open-telemetry#8203;evanphx](https://togithub.com/evanphx) in [hashicorp/go-hclog#134 #### New Contributors - [@&open-telemetry#8203;hashicorp-tsccr](https://togithub.com/hashicorp-tsccr) made their first contribution in [hashicorp/go-hclog#128 - [@&open-telemetry#8203;peteski22](https://togithub.com/peteski22) made their first contribution in [hashicorp/go-hclog#135 **Full Changelog**: hashicorp/go-hclog@v1.5.0...v1.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
](https://renovatebot.com){kind=link}
…#29814) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/hashicorp/go-hclog](https://togithub.com/hashicorp/go-hclog) | require | minor | `v1.5.0` -> `v1.6.2` | --- ### Release Notes <details> <summary>hashicorp/go-hclog (github.com/hashicorp/go-hclog)</summary> ### [`v1.6.2`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.2): Fix level syncing [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.6.1...v1.6.2) #### What's Changed - Conside if the level is to be used separately from if the levels should be calculated by [@&open-telemetry#8203;evanphx](https://togithub.com/evanphx) in [hashicorp/go-hclog#137 **Full Changelog**: hashicorp/go-hclog@v1.6.1...v1.6.2 ### [`v1.6.1`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.1): Fix forcing color [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.6.0...v1.6.1) #### What's Changed - Fix colors not being forced on correctly. by [@&open-telemetry#8203;evanphx](https://togithub.com/evanphx) in [hashicorp/go-hclog#136 **Full Changelog**: hashicorp/go-hclog@v1.6.0...v1.6.1 ### [`v1.6.0`](https://togithub.com/hashicorp/go-hclog/releases/tag/v1.6.0): New level inheritance mode [Compare Source](https://togithub.com/hashicorp/go-hclog/compare/v1.5.0...v1.6.0) This release adds the ability to have sub-loggers arrange themselves into a tree and sync the level changes downward in the tree. #### What's Changed - SEC-090: Automated trusted workflow pinning (2023-04-03) by [@&open-telemetry#8203;hashicorp-tsccr](https://togithub.com/hashicorp-tsccr) in [hashicorp/go-hclog#128 - Docs: InferLevelsWithTimestamp relies on InferLevels being true by [@&open-telemetry#8203;peteski22](https://togithub.com/peteski22) in [hashicorp/go-hclog#135 - Implement the ability to more logically share level hierarchies by [@&open-telemetry#8203;evanphx](https://togithub.com/evanphx) in [hashicorp/go-hclog#134 #### New Contributors - [@&open-telemetry#8203;hashicorp-tsccr](https://togithub.com/hashicorp-tsccr) made their first contribution in [hashicorp/go-hclog#128 - [@&open-telemetry#8203;peteski22](https://togithub.com/peteski22) made their first contribution in [hashicorp/go-hclog#135 **Full Changelog**: hashicorp/go-hclog@v1.5.0...v1.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that the color package we use was doing it's own "should
colors be on or not" detection, which interferred with our own
detection. This caused situations where colors were forced on to still
be off (and, maddeningly, would show up in weird contexts because it
dependent on Stdout being not a terminal to break when forced).
Fixes #127
Closes #131