Stepper - Convert components to TypeScript
#2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dhaulagiri
commented
May 17, 2024
| // Stepper | ||
| 'Hds::Stepper::Step::Indicator': typeof HdsStepperIndicatorStepComponent; | ||
| 'hds/stepper/step/indicator': typeof HdsStepperIndicatorStepComponent; | ||
| HdsStepperStepIndicator: typeof HdsStepperIndicatorStepComponent; |
There was a problem hiding this comment.
I got kinda dizzy trying to ensure I got Stepper Step & Indicator In the right order here. I think it's correct but a second set of eyes would be helpful. Ditto the section below as well.
Dhaulagiri
changed the title
Stepper - Convert components to TypeScript
didoo
reviewed
May 20, 2024
packages/components/src/components/hds/stepper/task/indicator.ts
Outdated
Show resolved
Hide resolved
packages/components/src/components/hds/stepper/task/indicator.ts
Outdated
Show resolved
Hide resolved
packages/components/src/components/hds/stepper/step/indicator.ts
Outdated
Show resolved
Hide resolved
packages/components/src/components/hds/stepper/step/indicator.ts
Outdated
Show resolved
Hide resolved
packages/components/src/components/hds/stepper/step/indicator.ts
Outdated
Show resolved
Hide resolved
packages/components/src/components/hds/stepper/task/indicator.ts
Outdated
Show resolved
Hide resolved
alex-ju
reviewed
May 20, 2024
Dhaulagiri
force-pushed
the
br-high-stepper
branch
from
6a23a39
to
058adb9
Compare
Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
Dhaulagiri
force-pushed
the
br-high-stepper
branch
from
058adb9
to
cb0ecd4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Converts the Stepper components to TS
🔗 External links
Jira ticket: HDS-2712
💬 Please consider using conventional comments when reviewing this PR.