Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separator - Convert to TypeScript #2114

Merged
merged 4 commits into from
May 20, 2024
Merged

Separator - Convert to TypeScript #2114

merged 4 commits into from
May 20, 2024

Conversation

Dhaulagiri
Copy link
Contributor

@Dhaulagiri Dhaulagiri commented May 17, 2024

📌 Summary

Converts the Separator comopnent to TS

🔗 External links

Jira ticket: HDS-2710


💬 Please consider using conventional comments when reviewing this PR.

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview May 20, 2024 1:48pm
hds-website ✅ Ready (Inspect) Visit Preview May 20, 2024 1:48pm

Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving, but don't forget to remove {{! @glint-nocheck: not typesafe yet }} from the template file

@Dhaulagiri
Copy link
Contributor Author

🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 i was even reading the instructions as I went through this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants