-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separator
- Convert to TypeScript
#2114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
didoo
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving, but don't forget to remove {{! @glint-nocheck: not typesafe yet }}
from the template file
Dhaulagiri
force-pushed
the
br-ts-separator
branch
from
May 17, 2024 19:53
46c5328
to
3bde75c
Compare
🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 i was even reading the instructions as I went through this. |
Dhaulagiri
force-pushed
the
br-ts-separator
branch
from
May 17, 2024 20:19
3bde75c
to
c5c596a
Compare
alex-ju
reviewed
May 20, 2024
Dhaulagiri
force-pushed
the
br-ts-separator
branch
from
May 20, 2024 13:44
c5c596a
to
a71324b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Converts the Separator comopnent to TS
🔗 External links
Jira ticket: HDS-2710
💬 Please consider using conventional comments when reviewing this PR.