feat(showcase): add typescript tooling #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aklkv
force-pushed
the
feat/showcase-ts-tooling
branch
from
0dd8855
to
6578861
Compare
aklkv
force-pushed
the
feat/showcase-ts-tooling
branch
from
6578861
to
9c0129b
Compare
aklkv
force-pushed
the
feat/showcase-ts-tooling
branch
from
c712c3f
to
9a6069c
Compare
aklkv
force-pushed
the
feat/showcase-ts-tooling
branch
from
171fe40
to
9a6069c
Compare
didoo
reviewed
May 21, 2024
showcase/.editorconfig
Outdated
There was a problem hiding this comment.
will the introduction of this file impact the existing files (eg. re-writing them, causing a lot of diffs in future PRs?)
should/could this file be added in a sepate PR? or would it impact this PR?
There was a problem hiding this comment.
I have not seen any changes in formatting on my end so I do believe this is a safe change and it will not introduce any charn
aklkv
force-pushed
the
feat/showcase-ts-tooling
branch
from
fc15fd1
to
42e54cd
Compare
alex-ju
approved these changes
May 22, 2024
alex-ju
force-pushed
the
feat/showcase-ts-tooling
branch
from
42e54cd
to
a992df6
Compare
|
Rebased and regenerated |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.