Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ButtonSet: Convert to TypeScript (HDS-2686) #2099

Merged
merged 4 commits into from
May 21, 2024
Merged

ButtonSet: Convert to TypeScript (HDS-2686) #2099

merged 4 commits into from
May 21, 2024

Conversation

KristinLBradley
Copy link
Contributor

@KristinLBradley KristinLBradley commented May 15, 2024 •
edited

📌 Summary

If merged, this PR converts the ButtonSet component to TypeScript.

🔗 External links

👀 Component checklist

  • [ ] Percy was checked for any visual regression
  • A changelog entry was added via Changesets if needed (see templates here)

💬 Please consider using conventional comments when reviewing this PR.

@vercel Vercel
Copy link

vercel bot commented May 15, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview May 21, 2024 3:33pm
hds-website ✅ Ready (Inspect) Visit Preview May 21, 2024 3:33pm

didoo
didoo approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KristinLBradley KristinLBradley requested a review from a team May 15, 2024 23:02
@KristinLBradley KristinLBradley force-pushed the hds-2686-buttonset-typescript-conversion branch from 6ccd5e8 to 1ba23de Compare May 17, 2024 16:46
@KristinLBradley KristinLBradley force-pushed the hds-2686-buttonset-typescript-conversion branch from 915e430 to 95ee008 Compare May 17, 2024 17:26
@KristinLBradley KristinLBradley force-pushed the hds-2686-buttonset-typescript-conversion branch from 0ac0d18 to 9c82030 Compare May 21, 2024 15:29
@KristinLBradley KristinLBradley merged commit 5a48c6c into main May 21, 2024
16 checks passed
@KristinLBradley KristinLBradley deleted the hds-2686-buttonset-typescript-conversion branch May 21, 2024 16:27
@hashibot-hds hashibot-hds mentioned this pull request May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didoo didoo didoo approved these changes

@natmegs natmegs natmegs left review comments

@alex-ju alex-ju alex-ju approved these changes

Assignees
No one assigned
Labels
packages/components typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@KristinLBradley @didoo @alex-ju @natmegs @hashibot-hds