-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabled state patterns Doc #2083
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
β¦, but is relevent to what products have in place now
β¦ading experience.
β¦n because it seems too product specific.
website/docs/patterns/disabled-patterns/partials/accessibility.md
Outdated
Show resolved
Hide resolved
website/docs/patterns/disabled-patterns/partials/accessibility.md
Outdated
Show resolved
Hide resolved
website/docs/patterns/disabled-patterns/partials/accessibility.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments with suggested edits.
Co-authored-by: Kristin Bradley <kristin.bradley@hashicorp.com>
Co-authored-by: Kristin Bradley <kristin.bradley@hashicorp.com>
website/docs/patterns/disabled-patterns/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/patterns/disabled-patterns/partials/guidelines/guidelines.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple more comments but I think this looking much better and is very close!
π Summary
If merged, this PR will incorporate Disabled state patterns from existing HCP documentation and add guidelines for disabled, visible, and hidden elements.
HDS-Website preview --------> Here π
π οΈ Detailed description
π External links
Part 1: Jira ticket: HDS-3312
Part 2: Jira ticket: HDS-3313
π Component checklist
π¬ Please consider using conventional comments when reviewing this PR.