Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled state patterns Doc #2083

Merged
merged 39 commits into from
May 31, 2024
Merged

Disabled state patterns Doc #2083

merged 39 commits into from
May 31, 2024

Conversation

andgen404
Copy link
Contributor

@andgen404 andgen404 commented May 8, 2024

πŸ“Œ Summary

If merged, this PR will incorporate Disabled state patterns from existing HCP documentation and add guidelines for disabled, visible, and hidden elements.

HDS-Website preview --------> Here πŸ‘€

πŸ› οΈ Detailed description

πŸ”— External links

Part 1: Jira ticket: HDS-3312
Part 2: Jira ticket: HDS-3313


πŸ‘€ Component checklist

πŸ’¬ Please consider using conventional comments when reviewing this PR.

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
hds-showcase βœ… Ready (Inspect) Visit Preview May 31, 2024 6:00pm
hds-website βœ… Ready (Inspect) Visit Preview May 31, 2024 6:00pm

Copy link
Contributor

@KristinLBradley KristinLBradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments with suggested edits.

Co-authored-by: Kristin Bradley <kristin.bradley@hashicorp.com>
Co-authored-by: Kristin Bradley <kristin.bradley@hashicorp.com>
Copy link
Contributor

@KristinLBradley KristinLBradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple more comments but I think this looking much better and is very close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants