Backport of test: force IPv4 on Docker 26+ to fix Envoy int tests into release/1.17.x #20989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/zalimeni/fix-envoy-int-tests-docker-26-force-ipv4/brightly-classic-lioness
branch
from
fbb5b5a
to
81c5806
Compare
github-team-consul-core-pr-approver
approved these changes
Apr 17, 2024
zalimeni
deleted the
backport/zalimeni/fix-envoy-int-tests-docker-26-force-ipv4/brightly-classic-lioness
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20986 to be assessed for backporting due to the inclusion of the label backport/1.17.
The below text is copied from the body of the original PR.
As of Docker Engine 26.0.0 (moby/moby#47062), IPv6 is enabled by default where supported. This causes issues for our tests attempting to resolve requests to other containers over localhost, since on Linux IPv6 will be preferred over IPv4 when available when applying the default behavior defined in RFC3484.
As a workaround, force IPv4 with a flag passed to
docker run.Testing & Reproduction steps
CI continues to pass (Docker Engine version is still <26 on runners used for CE builds).
Links
moby/moby#47062
PR Checklist
Overview of commits