Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of ci: Single source of truth for Go version in CI and Dockerfile into release/1.16.x #20161

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Backport of ci: Single source of truth for Go version in CI and Dockerfile into release/1.16.x #20161

merged 1 commit into from
Jan 11, 2024

Conversation

zalimeni
Copy link
Member

@zalimeni zalimeni commented Jan 11, 2024 •
edited

Manual backport of #20058 to release/1.16.x.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern
Overview of commits
  • 521493732f3f36908845751a978b4a88e1690301

@github-actions github-actions bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Jan 11, 2024
@zalimeni zalimeni force-pushed the backport/zalimeni/use-go-version-file/manual-1.16.x branch from f054296 to f8696a0 Compare January 11, 2024 02:35
@zalimeni zalimeni marked this pull request as ready for review January 11, 2024 14:23
@zalimeni zalimeni requested a review from a team January 11, 2024 14:23
@zalimeni zalimeni requested a review from a team as a code owner January 11, 2024 14:23
@zalimeni zalimeni requested review from emilymianeil, jeanneryan, curtbushko and wilkermichael and removed request for a team January 11, 2024 14:23
curtbushko
curtbushko approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zalimeni zalimeni merged commit eaf0106 into release/1.16.x Jan 11, 2024
93 checks passed
@zalimeni zalimeni deleted the backport/zalimeni/use-go-version-file/manual-1.16.x branch January 11, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtbushko curtbushko curtbushko approved these changes

@emilymianeil emilymianeil Awaiting requested review from emilymianeil

@jeanneryan jeanneryan Awaiting requested review from jeanneryan

@wilkermichael wilkermichael Awaiting requested review from wilkermichael

Assignees
No one assigned
Labels
pr/no-backport theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zalimeni @curtbushko