-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename daemon CLI command to cache #4808
Merged
johanbrandhorst
merged 3 commits into
main
from
jbrandhorst-deprecate-daemon-cli-command
May 22, 2024
Merged
Rename daemon CLI command to cache #4808
johanbrandhorst
merged 3 commits into
main
from
jbrandhorst-deprecate-daemon-cli-command
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
force-pushed
the
jbrandhorst-deprecate-daemon-cli-command
branch
from
May 17, 2024 23:28
03f3ff0
to
199464c
Compare
johanbrandhorst
changed the title
Deprecate daemon cli command
Rename daemon CLI command to cache
May 17, 2024
irenarindos
reviewed
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you need to also update website/data/docs-nav-data.json to reflect these changes
talanknight
approved these changes
May 20, 2024
stellarsquall
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
mikemountain
approved these changes
May 21, 2024
The deprecation wrapper can be used to display a warning to callers when a command is deprecated.
Rename the boundary daemon command to boundary cache. This avoids confusion with future client/daemons.
johanbrandhorst
force-pushed
the
jbrandhorst-deprecate-daemon-cli-command
branch
from
May 22, 2024 17:22
9999232
to
d7605e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates the
boundary daemon
command in favor ofboundary cache
. It also introduces a warning to users using the old command: