Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename daemon CLI command to cache #4808

Merged
merged 3 commits into from
May 22, 2024

Conversation

johanbrandhorst
Copy link
Collaborator

@johanbrandhorst johanbrandhorst commented May 17, 2024

Deprecates the boundary daemon command in favor of boundary cache. It also introduces a warning to users using the old command:

$ boundary daemon
The 'daemon' command is deprecated and will be removed in a future release. Please use the 'cache' command instead.
Usage: boundary cache [sub command] [options]

  This command allows interacting with the Boundary cache.

  Start a cache:

      $ boundary cache start

  For a full list of examples, please see the documentation.

Subcommands:
    add-token    Add an auth token to a running boundary cache
    start        Start a Boundary cache
    status       Get the status information of the running boundary cache
    stop         Stop the Boundary cache

@johanbrandhorst johanbrandhorst force-pushed the jbrandhorst-deprecate-daemon-cli-command branch from 03f3ff0 to 199464c Compare May 17, 2024 23:28
@johanbrandhorst johanbrandhorst changed the title Deprecate daemon cli command Rename daemon CLI command to cache May 17, 2024
@johanbrandhorst johanbrandhorst added this to the 0.17.x milestone May 17, 2024
@johanbrandhorst johanbrandhorst marked this pull request as ready for review May 17, 2024 23:29
@johanbrandhorst johanbrandhorst requested a review from a team as a code owner May 17, 2024 23:29
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need to also update website/data/docs-nav-data.json to reflect these changes

Copy link
Collaborator

@stellarsquall stellarsquall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

johanbrandhorst and others added 3 commits May 22, 2024 10:00
The deprecation wrapper can be used to display a warning to callers
when a command is deprecated.
Rename the boundary daemon command to boundary cache. This
avoids confusion with future client/daemons.
@johanbrandhorst johanbrandhorst force-pushed the jbrandhorst-deprecate-daemon-cli-command branch from 9999232 to d7605e4 Compare May 22, 2024 17:22
@johanbrandhorst johanbrandhorst merged commit e64443c into main May 22, 2024
64 checks passed
@johanbrandhorst johanbrandhorst deleted the jbrandhorst-deprecate-daemon-cli-command branch May 22, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants