Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🤖 Upgrade Electron to 26.x #1904

Merged
merged 1 commit into from Sep 19, 2023

Conversation

calcaide
Copy link
Collaborator

@calcaide calcaide commented Sep 19, 2023

🎟️ Jira ticket

Description

Upgrade Electron to 26.x version as per security concerns.

How to Test

  • Build successfully desktop client in local env.
  • Build successfully boundary-ui-release. Build here

Checklist:

- [ ] I have added before and after screenshots for UI changes
- [ ] I have added JSON response output for API changes

  • I have added steps to reproduce and test for bug fixes in the description
    - [ ] I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my feature works

@calcaide calcaide added the dependencies Pull requests that update a dependency file label Sep 19, 2023
@calcaide calcaide self-assigned this Sep 19, 2023
@calcaide calcaide requested a review from a team as a code owner September 19, 2023 00:13
@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 0:14am
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 0:14am

Copy link
Collaborator

@DhariniJeeva DhariniJeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@calcaide calcaide merged commit 7175bb5 into main Sep 19, 2023
12 checks passed
@calcaide calcaide deleted the chore-ICU-11041-upgrade-electron-to-26 branch September 19, 2023 22:28
@finnigja
Copy link
Contributor

finnigja commented Sep 28, 2023

For future reference, noting that this Electron update included a fix for CVE-2023-4863 (and dupe CVE-2023-5129) via the Chromium update in electron/electron#39828.

@calcaide
Copy link
Collaborator Author

Hey @finnigja thanks for commenting, I am sorry but I do not understand what you mean with your comment, can you please elaborate a bit?

We perform this update for 2 reasons:

  1. Security, to include the latest patches within chromium to solve the libwebp vulnerability.
  2. We are about to release a new version of the desktop client and wanted to make sure we packed with tha latest and greatest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file desktop ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants