Add --increment-inverse

[PenguinKeeper7]

See: #3959

(Submitted as a draft as it could do with a small clean-up and will likely need to be changed with future Atom's large commit anyway)

[virodoran]

This is awesome, I have been wanting this as a hashcat feature for ages.

One thing I'd suggest though is to not have it require the -i flag. In fact, I'd actually rather see it be mutually exclusive with -i so when running attacks you would choose between --increment and --increment-inverse.

I'd love a -ii shorthand (for increment inverse) or something too, but I guess hashcat doesn't have any other flags like that so maybe it would be weird... and -I is already taken unfortunately.

[roycewilliams]

I'd love a -ii shorthand (for increment inverse) or something too, but I guess hashcat doesn't have any other flags like that so maybe it would be weird... and -I is already taken unfortunately.

There are -II and -hh, at least - but so far, they seem to mean "do it more".

[PenguinKeeper7]

There are -II and -hh, at least - but so far, they seem to mean "do it more".

What's your opinion on -ii? Do you think it'd be out of place? I'm happy to implement it and I think it might be cool

[Shooter3k]

There are -II and -hh, at least - but so far, they seem to mean "do it more".

What's your opinion on -ii? Do you think it'd be out of place? I'm happy to implement it and I think it might be cool

personally, I love the -ii idea

[PenguinKeeper7]

@virodoran, --increment and --increment-inverse are no longer required together (0fb6e68)
@virodoran / @Shooter3k, -ii is now an alias for --increment-inverse (18a35bd)

[ventaquil]

Isn't it better to use an enum type for it?

Suggested change

	bool increment;
	bool increment_inverse;
	increment_t increment;

It could be just like the following:

typedef enum increment {
    INCREMENT_NONE,
    INCREMENT_NORMAL,
    INCREMENT_INVERSED,
} increment_t;