Implement AsFd and bidirectional conversion to/from OwnedFd
#202
Conversation
|
Thank you for the pull request, @joshtriplett! This looks good, but CI fails because our MSRV is too low. I've opened #203. I'll probably find some time to address this soon, but if anyone's reading this while I still haven't, feel free to jump in with a pull request! This PR is blocked until then.
I assume this means you need me to publish a new release, once this is merged? |
hannobraun
added
the
status: blocked
|
@hannobraun Right, this PR itself will raise the MSRV as well, for |
In particular, this makes it possible to get a `BorrowedFd` from an `Inotify`, which allows integration with polling mechanisms that don't use `RawFd`. This will be needed to work with the next version of `async-io`.
|
@hannobraun I've updated this to also fix the MSRV and CI. 1.63, which has the I/O Safety types stabilized, will ship in the Debian stable release shipping in a few days. And yes, I'd really appreciate a release with this change, once merged. |
hannobraun
removed
the
status: blocked
|
Thank you, @joshtriplett! It would have been a bit nicer go have the MSRV bump in a separate pull request, so I don't get confused later when writing the changelog. But this works too!
Understood. I'll try to get it out today. |
|
New version is out: #204, https://crates.io/crates/inotify/0.10.1 |
|
@hannobraun Thank you! |
In particular, this makes it possible to get a
BorrowedFdfrom anInotify, which allows integration with polling mechanisms that don'tuse
RawFd. This will be needed to work with the next version ofasync-io.