Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Node.js versions #2007

Merged
merged 1 commit into from
Sep 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
27 changes: 1 addition & 26 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,31 +25,6 @@ jobs:
- name: Lint
run: npm run lint

dependencies:
name: Test (dependencies)
runs-on: 'ubuntu-latest'
steps:
- name: Checkout
uses: actions/checkout@v2

- name: Setup Node.js
uses: actions/setup-node@v2
with:
# Node 14 ships with npm v6, which doesn't install peer-dependencies by default.
# Starting with npm v7 (which is shipped with Node >= 16), peer-dependencies are
# automatically installed. So this test (check for unmet peer-dependencies) only
# works with Node <= 14.
node-version: '14'

# Simulate an installation by a dependent package
- name: Install dependencies
run: |
rm package-lock.json
npm install --production

- name: Check dependency tree
run: npm ls

test:
name: Test (Node)
runs-on: ${{ matrix.operating-system }}
Expand All @@ -58,7 +33,7 @@ jobs:
matrix:
operating-system: ['ubuntu-latest', 'windows-latest']
# https://nodejs.org/en/about/releases/
node-version: ['12', '14', '16', '18', '20']
mohd-akram marked this conversation as resolved.
Show resolved Hide resolved
node-version: ['18', '20']

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "MIT",
"readmeFilename": "README.markdown",
"engines": {
"node": ">=12"
"node": ">=18"
},
"dependencies": {
"@handlebars/parser": "^2.1.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/multi-nodejs-test/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ cd "$( dirname "$( readlink -f "$0" )" )" || exit 1
unset npm_config_prefix

echo "Handlebars should be able to run in various versions of NodeJS"
for node_version_to_test in 12 14 16 18; do
for node_version_to_test in 18 20; do

rm target node_modules package-lock.json -rf
mkdir target
Expand Down