Don't rely on Nodejs global object

[jaylinski]

Description

If global is used and handlebars is compiled for browser
usage without a Node.js global polyfill, handlebars
fails with a global is undefined error.

Fixes #1593

---

• Please don't start pull requests for security issues. Instead, file a report at https://www.npmjs.com/advisories/report?package=handlebars
• Maintain the existing code style
• Are focused on a single change (i.e. avoid large refactoring or style adjustments in untouched code if not the primary goal of the pull request)
• Have good commit messages
• Have tests
• Have the typings (lib/handlebars.d.ts) updated on every API change. If you need help, updating those, please mention that in the PR description.
• Don't significantly decrease the current code coverage (see coverage/lcov-report/index.html)
• Currently, the 4.x-branch contains the latest version. Please target that branch in the PR.

[jaylinski]

@nknapp I created an example to reproduce the issue: https://github.com/jaylinski/handlebars.js/tree/no-global-reproduce/reproduce

It isn't an issue with default webpack 4 and webpack 5 settings, because global is automatically polyfilled. Related: webpack/webpack#11054

But it saves 0,5KB of size when node is set to false in webpack.

[jaylinski]

@jbboehr @nknapp Is there anything I can do to get this merged and released?

[tonyobanon]

@jbboehr @nknapp I am experiencing this issue as well cc @jaylinski

[tonyobanon]

@jbboehr @nknapp Is there anything I can do to get this merged and released?

@jaylinski Were you able to find a workaround?

[jaylinski]

@jaylinski Were you able to find a workaround?

Compiling handlebars with webpack will automatically polyfill global. If you don't use webpack, you have to polyfill global yourself.

[jaylinski]

Closed in favor of #1776.