Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(4.x): migrate from optimist to yargs #1662

Closed
wants to merge 2 commits into from
Closed

fix(4.x): migrate from optimist to yargs #1662

wants to merge 2 commits into from

Commits on Mar 19, 2020

  1. fix: migrate from optimist to yargs 

    closes #1658
adapted code from master to latest yargs (`.option` calls).

```
4.x:
found 188 vulnerabilities (169 low, 4 moderate, 14 high, 1 critical) in 5815 scanned packages

4.x with this PR:
found 32 vulnerabilities (17 low, 1 moderate, 13 high, 1 critical) in 5829 scanned packages
```
    @AviVahl
    AviVahl committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    e91bad6 View commit details
    Browse the repository at this point in the history

  2. fix: ensure external @types aren't picked up in test 

    some indirect dependencies install @types packages which are not compatible with the older typescript. adjusted test's tsconfig to not pick these up automatically, as the actual .d.ts does not depend on these external types.
    @AviVahl
    AviVahl committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    4b6e500 View commit details
    Browse the repository at this point in the history