Pass correct environment for AWS S3 publishing

See #1972
handlebars-lang · Jul 29, 2023 · 269163e · 269163e
1 parent bb55dea
commit 269163e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -4,13 +4,15 @@ on:
   push:
     branches:
       - master
+      - fix-aws-s3-publish-v3 # Delete me before merging!
     tags:
       - '*'
 
 jobs:
   publish-aws-s3:
     name: Publish to AWS S3
     runs-on: 'ubuntu-latest'
+    environment: 'builds.handlebarsjs.com.s3.amazonaws.com'
     steps:
       - name: Checkout
         uses: actions/checkout@v2
@@ -31,6 +33,6 @@ jobs:
           git config --global user.name "handlebars-lang"
           npm run publish:aws
         env:
-          # Note: the environment secrets `S3_ACCESS_KEY_ID`
-          #       and `S3_SECRET_ACCESS_KEY` have to be set!
           S3_BUCKET_NAME: "builds.handlebarsjs.com"
+          S3_ACCESS_KEY_ID: ${{ secrets.S3_ACCESS_KEY_ID }}
+          S3_SECRET_ACCESS_KEY: ${{ secrets.S3_SECRET_ACCESS_KEY }}
diff --git a/tasks/publish-to-aws.js b/tasks/publish-to-aws.js
@@ -26,6 +26,7 @@ module.exports = function (grunt) {
       suffixes.push('-' + commitInfo.tagName);
     }
 
+    initSDK(); // Remove me!
     if (suffixes.length > 0) {
       initSDK();
       grunt.log.writeln(