Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaked Wording #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

KennyOliver
Copy link
Contributor

It also said, "to order to".
I initially changed that to "in order to",
but then just got rid of the whole "to order" thing.

It also said, "to order to". 
I initially changed that to "in order to", 
but then just got rid of the whole "to order" thing.
@nknapp
Copy link
Contributor

nknapp commented Jun 21, 2022

Are you sure that capitalizing words is correct in english? I am a native german speaker, so I am not sure. But in the english translations that I am working on, we usually write every in small letters, except the first letter of the sentence.

@papasmile
Copy link
Contributor

Hi, All, to chime in as a native English speaker and webmaster...

  • That wording change is more succinct and makes sense
  • Capitalization of proper nouns (i.e. GitHub) is correct
  • Title case for button actions is an older web style that has fallen out of use. Take our PR for e.g., it has "Merge pull request" and "Close with comment" buttons. Call to action buttons are typically in regular sentence case nowadays

@nknapp
Copy link
Contributor

nknapp commented Jan 14, 2023

@papasmile just stumbled across this PR. What do you think?

  • Should we close it?
  • Was your last comment ("Title case for button actions...") meant as a change request to @KennyOliver ?

@papasmile
Copy link
Contributor

Hi, @nknapp, yea, I guess that last point was more of a change request but wanted to answer all your queries. Didn't hear back from OP, but I can wait a couple weeks, apply my suggestions, then merge if we don't hear back...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants