Skip to content

Commit

Permalink
Use node 18 in CI (#3167)
Browse files Browse the repository at this point in the history
  • Loading branch information
GrahamCampbell committed Aug 26, 2023
1 parent e21a355 commit 01531d1
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 9 deletions.
28 changes: 20 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ jobs:
extensions: mbstring, intl

- name: Set up Node
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: '14.x'
node-version: '18.x'

- name: Setup Problem Matchers for PHPUnit
run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"
Expand All @@ -36,8 +36,14 @@ jobs:
- name: Download dependencies
run: composer update --no-interaction --no-progress --prefer-stable --prefer-lowest

- name: Start test servers
shell: bash
run: |
node tests/server.js &
./vendor/bin/http_test_server &
- name: Run tests
run: make test
run: ./vendor/bin/phpunit

build:
name: Build
Expand Down Expand Up @@ -70,9 +76,9 @@ jobs:
extensions: mbstring, intl

- name: Set up Node
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: '14.x'
node-version: '18.x'

- name: Setup Problem Matchers for PHPUnit
run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"
Expand All @@ -85,8 +91,14 @@ jobs:
composer require --no-update "guzzlehttp/psr7:${{ matrix.psr7 }}"
composer update --no-interaction --no-progress
- name: Start test servers
shell: bash
run: |
node tests/server.js &
./vendor/bin/http_test_server &
- name: Run tests
run: make test
run: ./vendor/bin/phpunit

build-windows:
name: Build on Windows
Expand All @@ -106,9 +118,9 @@ jobs:
extensions: mbstring, intl

- name: Set up Node
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: '14.x'
node-version: '18.x'

- name: Setup Problem Matchers for PHPUnit
run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"
Expand Down
2 changes: 1 addition & 1 deletion tests/Server.php
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ public static function wait($maxTries = 5)
{
$tries = 0;
while (!self::isListening() && ++$tries < $maxTries) {
\usleep(100000);
\usleep(50000 * $tries ** 2);
}

if (!self::isListening()) {
Expand Down

0 comments on commit 01531d1

Please sign in to comment.