Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update!: remove --verify #251

Merged
merged 2 commits into from
Jan 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,6 @@ __Some flags only work with gulp 4 and will be ignored when invoked against gulp
<td></td>
<td>Manually set the CWD. The search for the gulpfile, as well as the relativity of all preloads (with the `--preload` flag) will be from here.</td>
</tr>
<tr>
<td>--verify [path (optional)]</td>
<td></td>
<td>Will verify plugins referenced in project's package.json against the plugins blacklist.</td>
</tr>
<tr>
<td>--tasks</td>
<td>-T</td>
Expand Down
3 changes: 0 additions & 3 deletions docs/CLI.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,6 @@ gulp has very few flags to know about. All other flags are for tasks to use if n
**--cwd** [path]
Manually set the CWD. The search for the gulpfile, as well as the relativity of all requires will be from here.

**--verify** [path (optional)]
Will verify plugins referenced in project's package.json against the plugins blacklist.

**--tasks**, **-T**
Print the task dependency tree for the loaded gulpfile.

Expand Down
25 changes: 0 additions & 25 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,12 @@ var tildify = require('./lib/shared/tildify');
var makeTitle = require('./lib/shared/make-title');
var parser = require('./lib/shared/options/parser');
var completion = require('./lib/shared/completion');
var verifyDeps = require('./lib/shared/verify-dependencies');
var cliVersion = require('./package.json').version;
var getBlacklist = require('./lib/shared/blacklist');
var toConsole = require('./lib/shared/log/to-console');

var mergeProjectAndUserHomeConfigs = require('./lib/shared/config/merge-configs');
var overrideEnvFlagsByConfigAndCliOpts = require('./lib/shared/config/env-flags');

// Logging functions
var logVerify = require('./lib/shared/log/verify');
var logBlacklistError = require('./lib/shared/log/blacklist-error');

// Get supported ranges
var ranges = fs.readdirSync(path.join(__dirname, '/lib/versioned/'));

Expand Down Expand Up @@ -150,25 +144,6 @@ function onExecute(env) {
exit(0);
}

if (env.config.flags.verify) {
var pkgPath = env.config.flags.verify !== true ? env.config.flags.verify : 'package.json';
/* istanbul ignore else */
if (path.resolve(pkgPath) !== path.normalize(pkgPath)) {
pkgPath = path.join(env.cwd, pkgPath);
}
log.info('Verifying plugins in ' + pkgPath);
return getBlacklist(function(err, blacklist) {
phated marked this conversation as resolved.
Show resolved Hide resolved
/* istanbul ignore if */
if (err) {
return logBlacklistError(err);
}

var blacklisted = verifyDeps(require(pkgPath), blacklist);

logVerify(blacklisted);
});
}

if (!env.modulePath) {
/* istanbul ignore next */
var missingNodeModules =
Expand Down
39 changes: 0 additions & 39 deletions lib/shared/blacklist/get-remote-json.js

This file was deleted.

11 changes: 0 additions & 11 deletions lib/shared/blacklist/index.js

This file was deleted.

15 changes: 0 additions & 15 deletions lib/shared/log/blacklist-error.js

This file was deleted.

28 changes: 0 additions & 28 deletions lib/shared/log/verify.js

This file was deleted.

5 changes: 0 additions & 5 deletions lib/shared/options/parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,6 @@ var options = {
'Manually set the CWD. The search for the gulpfile, ' +
'as well as the relativity of all requires will be from here.'),
},
verify: {
desc: chalk.gray(
'Will verify plugins referenced in project\'s package.json against ' +
'the plugins blacklist.'),
},
tasks: {
alias: 'T',
type: 'boolean',
Expand Down
34 changes: 0 additions & 34 deletions lib/shared/verify-dependencies.js

This file was deleted.

2 changes: 0 additions & 2 deletions test/expected/flags-help.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ Options:
--cwd Manually set the CWD. The search for the gulpfile,
as well as the relativity of all requires will be
from here. [string]
--verify Will verify plugins referenced in project's
package.json against the plugins blacklist.
-T, --tasks Print the task dependency tree for the loaded
gulpfile. [boolean]
--tasks-simple Print a plaintext list of tasks for the loaded
Expand Down
73 changes: 0 additions & 73 deletions test/flags-verify.js

This file was deleted.

34 changes: 0 additions & 34 deletions test/lib/get-remote-json.js

This file was deleted.