make payment-api use java 21 #5802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.78 MB ℹ️ View Unchanged
|
johnduffell
commented
Mar 14, 2024
| @@ -2,8 +2,8 @@ import sbtrelease.ReleaseStateTransformations._ | |||
|
|
|||
| name := "support-internationalisation" | |||
|
|
|||
| scalaVersion := "3.2.2" // beware >= 3.1.3 has an incompatibility with <= 2.13.8 which causes compile issue `Unsupported Scala 3 generic tuple type scala.Tuple in bounds of type MirroredElemTypes; found in scala.deriving.Mirror.<refinement>.` | |||
| crossScalaVersions := Seq("2.13.8", "3.2.2") | |||
| scalaVersion := "3.3.3" | |||
There was a problem hiding this comment.
comment no longer needed since the days of scala/scala3#15878 are passed
|
Seen on PROD (merged by @johnduffell 12 minutes and 3 seconds ago)
Sentry Release: support-client-side, support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows on from updating support-frontend to java 21 #5801
This one updates payment api similarly, also updates the JDK used to compile to java 21
Note there is a bug in 2.13.13 so I didn't update the main scala version, but it will be fixed in 2.13.14 scala/bug#12955
Payment API deploys ok in CODE and I could do a single contribution