Add Java version - see guardian/gha-scala-library-release-workflow#36 #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjsilver
approved these changes
May 20, 2024
There was a problem hiding this comment.
The artifacts currently support Java v8 - should we change this to v11 now?
Line 32 in 57920ed
rtyley
force-pushed
the
add-java-version
branch
2 times, most recently
from
ad27590
to
823fdd2
Compare
Although we're _building_ with Java 21, we're also updating the minimum supported Java version from Java 8 to Java 11: #442 (review) We can do this because the artifact published by this repo: "com.gu" %% "janus-config-tools" % "1.0.0" https://index.scala-lang.org/guardian/janus-app/artifacts/janus-config-tools ...is only consumed by these two apps, Janus & Security HQ: * guardian/janus#3947 * guardian/security-hq#413 ....both of which are now running on Java 11.
Yes, good idea! We can do this because the artifact published by this repo:
...is only consumed by these two apps, Janus & Security HQ: ....both of which are already running on Java 11! Done with 5d660c2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See guardian/gha-scala-library-release-workflow#36 -
gha-scala-library-release-workflowhas moved to requiring projects to specify what version of Java they want to use to build, and this is expressed through anasdf-formatted.tool-versionsfile.This allows individual projects to experiment with later (or even earlier) versions of Java if they wish, without requiring all other projects using
gha-scala-library-release-workflowto upgrade their version of Java at the same time."But maybe we need to support older versions of Java!"
Note that, although this PR specifies Java 21 (the latest LTS release of Java, which apparently has several performance benefits) for the library build, the artifacts released by the project do not need to require Java 21 - so long as the
scalacOptionsdefined in the project'sbuild.sbtincludes a-releaseflag, we can specify that we want the artifacts to support some older version of Java (eg-release:11for Java 11).