Use common Space type across components
#1433
Open
+149
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1d8ff16 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Tip Once this PR is ready to go, add the This saves us a lot of money by not running the tests before we need them. |
jamesmockett
added
run_chromatic
sndrs
approved these changes
May 8, 2024
jamesmockett
changed the title
Space type across components
Good point. I was thinking this doesn't need a release, but I suppose it does expose some new spacing values in those components. I'll add a changeset… |
jamesmockett
force-pushed
the
jm/use-common-space-type
branch
2 times, most recently
from
fb656fa
to
0091e4b
Compare
jamesmockett
force-pushed
the
jm/use-common-space-type
branch
from
0091e4b
to
6ded5c7
Compare
jamesmockett
force-pushed
the
jm/use-common-space-type
branch
from
0a68247
to
fb2f807
Compare
jamesmockett
commented
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing?
Spacetype in components that accept spacing values as props.space.0is used due to0being falsy.Stackstories to better show how spacing is applied.InlineandStackstories to include examples of all spacing values.Why?