Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nx → wireit #1386

Merged
merged 6 commits into from May 16, 2024
Merged

Nx → wireit #1386

merged 6 commits into from May 16, 2024

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Apr 28, 2024 •
edited

What are you changing?

swap out Nx for wireit

Why?

it's much more lightweight, and is only concerned orchestrating tasks, rather than providing deps, generators, plugins etc.

we think it will make it easier to manage the repo and present a far smaller learning curve to new users of the repo

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2024 •
edited

⚠️ No Changeset found

Latest commit: 40720d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@sndrs sndrs force-pushed the sndrs/de-nx branch 2 times, most recently from 4cf9beb to 544dedb Compare April 30, 2024 14:50
@sndrs sndrs force-pushed the sndrs/esmodules branch 5 times, most recently from 0ed5b7a to 642fe5f Compare May 7, 2024 14:34
Base automatically changed from sndrs/esmodules to main May 8, 2024 09:05
@sndrs sndrs closed this May 8, 2024
@sndrs sndrs reopened this May 8, 2024
@sndrs sndrs changed the title [poc] Remove Nx Nx → wireit May 8, 2024
@sndrs sndrs linked an issue May 8, 2024 that may be closed by this pull request
Transition from Nx to wireit #1310
Closed
@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label May 8, 2024
@sndrs sndrs marked this pull request as ready for review May 8, 2024 13:27
@sndrs sndrs requested a review from a team as a code owner May 8, 2024 13:27
@sndrs sndrs requested review from a team as code owners May 8, 2024 13:27
oliverabrahams
oliverabrahams reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@oliverabrahams oliverabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! added some comments about dependencies

libs/@guardian/source-react-components-development-kitchen/package.json Show resolved Hide resolved
libs/@guardian/source-react-components/package.json Show resolved Hide resolved
libs/@guardian/source-react-components-development-kitchen/package.json Show resolved Hide resolved
sndrs and others added 4 commits May 16, 2024 10:20
@sndrs
build design tokens to the correct place
35b27ff
@oliverabrahams
Rollup config fix
67c4526
@sndrs @jamesmockett @oliverabrahams
add a npm script running checker
bcd6b93 
Co-authored-by: James Mockett <1166188+jamesmockett@users.noreply.github.com>
Co-authored-by: Oliver Abrahams <ollie.abrahams@guardian.co.uk>
@sndrs
prettify typography generated code
40720d7
@sndrs sndrs enabled auto-merge (squash) May 16, 2024 11:42
@sndrs sndrs merged commit 32ecd98 into main May 16, 2024
20 checks passed
@sndrs sndrs deleted the sndrs/de-nx branch May 16, 2024 11:43
@sndrs sndrs mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverabrahams oliverabrahams oliverabrahams approved these changes

Assignees
No one assigned
Labels
@guardian/ab-core @guardian/ab-react @guardian/browserslist-config @guardian/eslint-config @guardian/eslint-config-typescript @guardian/libs @guardian/prettier @guardian/tsconfig 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied 🛠 workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transition from Nx to wireit
2 participants
@sndrs @oliverabrahams