Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the link component to use the new presets #1289

Closed
wants to merge 7 commits into from
Closed

Update the link component to use the new presets #1289

wants to merge 7 commits into from

Conversation

oliverabrahams
Copy link
Contributor

What are you changing?

  • Update the link component to use the new presets instead of having to use the css custom properties

Why?

  • When creating the new presets, it was a chance to remove the source specific css custom property

@oliverabrahams oliverabrahams requested review from a team as code owners March 18, 2024 09:39
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2024 •
edited

⚠️ No Changeset found

Latest commit: ad98d58

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Mar 18, 2024
@oliverabrahams oliverabrahams linked an issue Mar 18, 2024 that may be closed by this pull request
Get link component calculating its own text underline thickness from presets #1288
Open
@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Mar 21, 2024
jamesmockett
jamesmockett reviewed Mar 21, 2024
View reviewed changes
libs/@guardian/source-react-components/src/link/styles.ts
text-underline-offset: 5%;
${typographyPreset};
display: inline;
text-decoration-thickness: 0.1em;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we nudge this up a couple of lines so it's grouped with the other text decoration properties?

@jamesmockett jamesmockett mentioned this pull request Mar 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmockett jamesmockett jamesmockett left review comments

Assignees
No one assigned
Labels
🎨 Design System 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get link component calculating its own text underline thickness from presets
3 participants
@oliverabrahams @jamesmockett @sndrs