Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get link component calculating its own text underline thickness from presets #1288

Open
oliverabrahams opened this issue Mar 18, 2024 · 2 comments
Open

Get link component calculating its own text underline thickness from presets #1288

oliverabrahams opened this issue Mar 18, 2024 · 2 comments
Assignees
@oliverabrahams
Labels
🎨 Design System

Comments

@oliverabrahams
Copy link
Contributor

No description provided.

@oliverabrahams oliverabrahams self-assigned this Mar 18, 2024
@oliverabrahams oliverabrahams linked a pull request Mar 18, 2024 that will close this issue
Update the link component to use the new presets #1289
Closed
@jamesmockett
Copy link
Contributor

Akemi is reviewing the default values for underline thickness as it varies across browsers, and whether we can calculate this as a percentage to simplify our code and remove the need for the custom property in the presets.

@SiAdcock
Copy link
Contributor

@jamesmockett shall we chase Faye at the next DS/CSTI planning session?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverabrahams oliverabrahams

Labels
🎨 Design System
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the link component to use the new presets guardian/csnx
3 participants
@jamesmockett @SiAdcock @oliverabrahams