Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENT] add bulk ingest for hasSBOM nodes #1915

Merged
merged 2 commits into from
May 17, 2024
Merged

[ENT] add bulk ingest for hasSBOM nodes #1915

merged 2 commits into from
May 17, 2024

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented May 17, 2024 •
edited

Description of the PR

add bulk ingest for hasSBOM nodes. This was initially not added but will be needed for full optimization.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@pxp928
add bulk ingest for hasSBOM nodes
28ac159 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add err check for no rows
dc49363 
Signed-off-by: pxp928 <parth.psu@gmail.com>
mrizzi
mrizzi approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pxp928 great addition, thanks 👍

mihaimaruseac
mihaimaruseac approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you!

@kodiakhq kodiakhq bot merged commit f478bf0 into guacsec:main May 17, 2024
8 checks passed
@pxp928 pxp928 deleted the ent-batchHasSBOM branch May 17, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@mrizzi mrizzi mrizzi approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pxp928 @mihaimaruseac @mrizzi