Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included a Handler for CycloneDX Version Ranges #1789

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

nathannaveen
Copy link
Contributor

Description of the PR

  • Includes a hander for the CycloneDX version ranges.
  • Includes tests for the version range parser
  • Partially fixes [bug] CycloneDX ingestion failing #1148
  • Passes down the graphql client to CycloneDX from the top (Also passing it down to all the other parsers). This is so that we can call model.Packages.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@nathannaveen nathannaveen force-pushed the nathan/versionRangesForCycloneDX branch 2 times, most recently from bd89b6c to 0d00394 Compare March 26, 2024 14:40
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nathannaveen nathannaveen force-pushed the nathan/versionRangesForCycloneDX branch from 23e39ec to f234758 Compare March 27, 2024 13:28
@nathannaveen
Copy link
Contributor Author

@pxp928 Thanks, I fixed the test!

Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of changes/questions. Were you able to test this with any examples?

pkg/ingestor/parser/cyclonedx/parser_cyclonedx.go Outdated Show resolved Hide resolved
pkg/ingestor/parser/cyclonedx/parser_cyclonedx.go Outdated Show resolved Hide resolved
pkg/ingestor/parser/cyclonedx/parser_cyclonedx.go Outdated Show resolved Hide resolved
@nathannaveen nathannaveen force-pushed the nathan/versionRangesForCycloneDX branch 3 times, most recently from a56894a to a06a21f Compare April 19, 2024 16:22
* Included a version range parser for CycloneDX

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen nathannaveen force-pushed the nathan/versionRangesForCycloneDX branch from b5bec6a to c35c59f Compare May 10, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] CycloneDX ingestion failing
2 participants