Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Race Conditions for parser_dsee_test and prometheus_test #1348

Closed
wants to merge 1 commit into from
Closed

Fixed Race Conditions for parser_dsee_test and prometheus_test #1348

wants to merge 1 commit into from

Conversation

neilnaveen
Copy link
Contributor

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@neilnaveen
Fixed Race Conditions for parser_dsee_test and prometheus_test
9a8690a 
- fixed the data race condition

Signed-off-by: Neil Naveen <42328488+neilnaveen@users.noreply.github.com>
pxp928
pxp928 reviewed Oct 4, 2023
View reviewed changes
pkg/ingestor/parser/dsse/parser_dsse_test.go
"github.com/guacsec/guac/pkg/logging"
)

var once sync.Once
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment: https://github.com/guacsec/guac/pull/1345/files#r1346104106. Previous PR might also need to be fixed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A friendly ping @pxp928 @lumjjb pertaining #1345 (comment)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lumjjb did you want to expand here to complete this PR?

@stale Stale
Copy link

stale bot commented Dec 16, 2023

This pull request has been automatically marked as stale because it has not had recent activity (60 days of inactivity).
It will be closed in 30 days if no further activity occurs.
Thank you for your contribution!

@stale stale bot added the wontfix This will not be worked on label Dec 16, 2023
@stale Stale
Copy link

stale bot commented Jan 15, 2024

This pull request has been automatically closed because there has been no activity for 90 days.
Please feel free to reopen it (or open a new one) if the proposed change is still appropriate.
Thank you for your contribution!

@stale stale bot closed this Jan 15, 2024
@pxp928
Copy link
Collaborator

pxp928 commented Jan 15, 2024

Reopening this to address this issue.

@pxp928 pxp928 reopened this Jan 15, 2024
@stale stale bot removed the wontfix This will not be worked on label Jan 15, 2024
@stale Stale
Copy link

stale bot commented May 6, 2024

This pull request has been automatically marked as stale because it has not had recent activity (60 days of inactivity).
It will be closed in 30 days if no further activity occurs.
Thank you for your contribution!

@stale stale bot added the wontfix This will not be worked on label May 6, 2024
@stale Stale
Copy link

stale bot commented Jun 6, 2024

This pull request has been automatically closed because there has been no activity for 90 days.
Please feel free to reopen it (or open a new one) if the proposed change is still appropriate.
Thank you for your contribution!

@stale stale bot closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxp928 pxp928 pxp928 left review comments

Assignees
No one assigned
Labels
size/S wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@neilnaveen @pxp928