Add OCI registry collector #1279
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| if err != nil { | ||
| return fmt.Errorf("unable to retrieve artifacts from OCI collector: %w", err) | ||
| } | ||
| o.checkedDigest = ociCollector.checkedDigest |
There was a problem hiding this comment.
hmm the oci collector could skip all those that are duplicates. So no checks have to be done at the OCI registry collector.
|
|
||
| rcOpts := getRegClientOptions() | ||
| rc := regclient.New(rcOpts...) | ||
| defer rc.Close(ctx, r) |
There was a problem hiding this comment.
The error returned from ref.New is not checked before passing r to rc.Close.
This could lead to a panic if ref.New returns an error.
| if err != nil { | ||
| return fmt.Errorf("failed to list repositories in registry %s: %w", o.registry, err) | ||
| } | ||
| if len(rl.Repositories) == 0 { |
There was a problem hiding this comment.
rl.Repositories is not checked for nil. This could cause a panic.
Suggestion: Add nil check on rl.Repositories.
|
|
||
| rcOpts := getRegClientOptions() | ||
| rc := regclient.New(rcOpts...) | ||
| defer rc.Close(ctx, r) |
There was a problem hiding this comment.
Close can return an error. This would not be noticed if someone is trying to debug.
A recommendation would be to log this.
defer func(rc *regclient.RegClient, ctx context.Context, r ref.Ref) {
err := rc.Close(ctx, r)
if err != nil {
//log error
}
}(rc, ctx, r)
ridhoq
force-pushed
the
ridhoq/oci-registry-collector
branch
from
ddcd05f
to
4b6e5c8
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity (60 days of inactivity). |
|
This pull request has been automatically closed because there has been no activity for 90 days. |
|
Re-opening this pull request as this is a feature that we want to add. FYI @ridhoq |
|
@ridhoq did you have any cycles to complete this PR? Would be a great feature to add in. |
|
Pinging this one so it doesn't close |
Signed-off-by: Ridwan Hoq <ridwanhoq@microsoft.com>
ridhoq
force-pushed
the
ridhoq/oci-registry-collector
branch
from
4b6e5c8
to
5a6ad76
Compare
Description of the PR
Support collecting all OCI artifacts in an OCI registry that has the
/v2/_catalogendpoint enabled.TODO:
guaconeandguaccollect?Fixes #298
PR Checklist
-sflag togit commit.make generatehas been runcollectsubprotobuf has been changed,make protohas been run