Client pod logs can now stream with or without newlines #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gtsystem Maybe this provides better flexibility for streaming the logs |
gtsystem
reviewed
Apr 15, 2023
Co-authored-by: Giuseppe Tribulato <gtsystem@users.noreply.github.com>
Co-authored-by: Giuseppe Tribulato <gtsystem@users.noreply.github.com>
addyess
force-pushed
the
pod/log/newlines
branch
from
13f4b56
to
049e380
Compare
gtsystem
approved these changes
Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding upstream changes encode/httpx#2423 lightkube should offer a way to maintain newlines while streaming pod logs