Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s): honor options.RestConfig in tunnel.ForwardPortE #1464

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

jduepmeier
Copy link
Contributor

@jduepmeier jduepmeier commented Nov 7, 2024

The tunnel.ForwardPortE function does not honor the rest config configured inside the KubectlOptions. This leads to a mismatch with other functions.

This commit uses the RestConfig if defined instead of getting a new one.

Description

Fixes #1463.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

fix(k8s): honor options.RestConfig in tunnel.ForwardPortE

Sorry, something went wrong.

The tunnel.ForwardPortE function does not honor the rest config
configured inside the KubectlOptions. This leads to a mismatch with
other functions.

This commit uses the RestConfig if defined instead of getting a new one.
@jduepmeier jduepmeier requested a review from denis256 as a code owner November 7, 2024 12:04
@denis256 denis256 merged commit bb92e35 into gruntwork-io:main Dec 17, 2024
2 of 3 checks passed
@jduepmeier jduepmeier deleted the tunnel-k8s-rest-client branch December 18, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8s tunnel.ForwardPortE does not honor options.RestConfig
4 participants