Add configuration options for AWS S3 server access logging #3006

findmyname666 · 2024-03-18T08:01:54Z

Description

In our environment the S3 bucket where should be stored S3 access logs is pre-created by "central" team and we don't have permissions to do any changes. In such case we don't have to:

Create it - the current code creates the logging bucket only if it doesn't exist. No change is needed.
Configure logging bucket e.g. ACL, public access, encryption, tls enforcement - adding option to skip the configuration for access log bucket.
PartitionDateSource - Adding one more option to allow users to configure PartitionDateSource.

Additionally 1) adding error logging into the function configureAccessLogBucket. Without it I wasn't able to detect why the logging isn't configured on the source bucket. The error is returned but ignored. 2) Adding code to detect if the logging policy / configuration was change. The previous code just check if some policy is enabled.

TODOs

Read the Gruntwork contribution guidelines.

Update the docs.
Run the relevant tests successfully, including pre-commit checks.
Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

N/A.

denis256 · 2024-03-19T18:25:24Z

remote/remote_state_s3.go

+	SkipAccessLoggingBucketAcl                   bool              `mapstructure:"skip_accesslogging_bucket_acl"`
+	SkipAccessLoggingBucketEnforcedTLS           bool              `mapstructure:"skip_accesslogging_bucket_enforced_tls"`
+	SkipAccessLoggingBucketPublicAccessBlocking  bool              `mapstructure:"skip_accesslogging_bucket_public_access_blocking"`
+	SkipAccessLoggingBucketSSEncryption          bool              `mapstructure:"skip_accesslogging_bucket_ssencryption"`


Could you please consider adding tests to ensure that the newly added fields are functioning as expected?

Hi @denis256, Thx for your feedback. I tried to updated existing existing tests and added one new for method createS3LoggingInput. Please let me know if I missed anything else.

Hi @denis256 , Can I politely ask you for re-review once you have some free time please? Thx.

Hi @denis256, do you think you'll have time to take a look on this PR in the upcoming days?

yhakbar · 2024-08-05T13:33:31Z

Hey @findmyname666 , are you willing to rebase to get this PR up to speed?

Also, are you able to run the tests locally to confirm that they work as expected?

findmyname666 · 2024-08-07T09:03:01Z

Hey @findmyname666 , are you willing to rebase to get this PR up to speed?

Also, are you able to run the tests locally to confirm that they work as expected?

Hi @yhakbar , I will try to do it this week. Thx.

sonarqubecloud · 2024-08-09T14:00:29Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

findmyname666 · 2024-08-09T14:16:11Z

Hey @findmyname666 , are you willing to rebase to get this PR up to speed?

Also, are you able to run the tests locally to confirm that they work as expected?

Hi @yhakbar,

I re-based the code and re-tested remote package:

$ go test -v
=== RUN   TestGCSConfigValuesEqual
=== PAUSE TestGCSConfigValuesEqual
=== RUN   TestCreateS3LoggingInput
=== PAUSE TestCreateS3LoggingInput
=== RUN   TestConfigValuesEqual
=== PAUSE TestConfigValuesEqual
=== RUN   TestForcePathStyleClientSession
=== PAUSE TestForcePathStyleClientSession
=== RUN   TestGetAwsSessionConfig
=== PAUSE TestGetAwsSessionConfig
=== RUN   TestGetAwsSessionConfigWithAssumeRole
=== PAUSE TestGetAwsSessionConfigWithAssumeRole
=== RUN   TestGetTerraformInitArgs
=== PAUSE TestGetTerraformInitArgs
=== RUN   TestNegativePublicAccessResponse
=== PAUSE TestNegativePublicAccessResponse
=== RUN   TestValidateS3Config
=== PAUSE TestValidateS3Config
=== RUN   TestToTerraformInitArgs
=== PAUSE TestToTerraformInitArgs
=== RUN   TestToTerraformInitArgsForGCS
=== PAUSE TestToTerraformInitArgsForGCS
=== RUN   TestToTerraformInitArgsUnknownBackend
=== PAUSE TestToTerraformInitArgsUnknownBackend
=== RUN   TestToTerraformInitArgsInitDisabled
=== PAUSE TestToTerraformInitArgsInitDisabled
=== RUN   TestToTerraformInitArgsNoBackendConfigs
=== PAUSE TestToTerraformInitArgsNoBackendConfigs
=== RUN   TestDiffersFrom
=== PAUSE TestDiffersFrom
=== RUN   TestWrapMapToSingleLineHcl
=== RUN   TestWrapMapToSingleLineHcl/SimpleMap
=== RUN   TestWrapMapToSingleLineHcl/NestedMap
--- PASS: TestWrapMapToSingleLineHcl (0.00s)
    --- PASS: TestWrapMapToSingleLineHcl/SimpleMap (0.00s)
    --- PASS: TestWrapMapToSingleLineHcl/NestedMap (0.00s)
=== RUN   TestParseTerraformStateLocal
=== PAUSE TestParseTerraformStateLocal
=== RUN   TestParseTerraformStateRemote
=== PAUSE TestParseTerraformStateRemote
=== RUN   TestParseTerraformStateRemoteFull
=== PAUSE TestParseTerraformStateRemoteFull
=== RUN   TestParseTerraformStateEmpty
=== PAUSE TestParseTerraformStateEmpty
=== RUN   TestParseTerraformStateInvalid
=== PAUSE TestParseTerraformStateInvalid
=== CONT  TestGCSConfigValuesEqual
=== CONT  TestDiffersFrom
=== RUN   TestGCSConfigValuesEqual/equal-both-empty
=== PAUSE TestGCSConfigValuesEqual/equal-both-empty
=== RUN   TestGCSConfigValuesEqual/equal-empty-and-nil
=== RUN   TestDiffersFrom/both_empty
=== PAUSE TestGCSConfigValuesEqual/equal-empty-and-nil
=== PAUSE TestDiffersFrom/both_empty
=== RUN   TestGCSConfigValuesEqual/equal-empty-and-nil-backend-config
=== RUN   TestDiffersFrom/same_backend_type_value
=== PAUSE TestDiffersFrom/same_backend_type_value
=== RUN   TestDiffersFrom/different_backend_type_values
=== PAUSE TestDiffersFrom/different_backend_type_values
=== RUN   TestDiffersFrom/identical_S3_configs
=== PAUSE TestDiffersFrom/identical_S3_configs
=== RUN   TestDiffersFrom/identical_GCS_configs
=== PAUSE TestDiffersFrom/identical_GCS_configs
=== CONT  TestParseTerraformStateRemoteFull
=== PAUSE TestGCSConfigValuesEqual/equal-empty-and-nil-backend-config
=== CONT  TestParseTerraformStateRemote
=== RUN   TestGCSConfigValuesEqual/equal-one-key
=== PAUSE TestGCSConfigValuesEqual/equal-one-key
=== CONT  TestNegativePublicAccessResponse
--- PASS: TestParseTerraformStateRemote (0.00s)
=== CONT  TestToTerraformInitArgsInitDisabled
--- PASS: TestToTerraformInitArgsInitDisabled (0.00s)
=== CONT  TestToTerraformInitArgsUnknownBackend
=== RUN   TestNegativePublicAccessResponse/nil-response
--- PASS: TestToTerraformInitArgsUnknownBackend (0.00s)
=== CONT  TestToTerraformInitArgsForGCS
=== PAUSE TestNegativePublicAccessResponse/nil-response
=== CONT  TestToTerraformInitArgs
=== RUN   TestNegativePublicAccessResponse/legacy-bucket
=== PAUSE TestNegativePublicAccessResponse/legacy-bucket
=== CONT  TestToTerraformInitArgsNoBackendConfigs
=== RUN   TestNegativePublicAccessResponse/false-response
=== CONT  TestValidateS3Config
=== PAUSE TestNegativePublicAccessResponse/false-response
=== CONT  TestGetAwsSessionConfig
=== CONT  TestGetAwsSessionConfigWithAssumeRole
=== RUN   TestGetAwsSessionConfigWithAssumeRole/all-values
=== PAUSE TestGetAwsSessionConfigWithAssumeRole/all-values
--- PASS: TestToTerraformInitArgsForGCS (0.00s)
=== CONT  TestConfigValuesEqual
=== RUN   TestGetAwsSessionConfig/all-values
=== RUN   TestValidateS3Config/no-region
=== PAUSE TestGetAwsSessionConfig/all-values
=== RUN   TestGetAwsSessionConfig/no-values
=== CONT  TestParseTerraformStateEmpty
=== PAUSE TestGetAwsSessionConfig/no-values
=== CONT  TestForcePathStyleClientSession
=== RUN   TestGetAwsSessionConfig/extra-values
=== PAUSE TestGetAwsSessionConfig/extra-values
=== RUN   TestDiffersFrom/different_s3_bucket_values
=== PAUSE TestDiffersFrom/different_s3_bucket_values
=== RUN   TestDiffersFrom/different_gcs_bucket_values
=== PAUSE TestDiffersFrom/different_gcs_bucket_values
=== CONT  TestCreateS3LoggingInput
=== RUN   TestGCSConfigValuesEqual/equal-multiple-keys
=== PAUSE TestGCSConfigValuesEqual/equal-multiple-keys
=== RUN   TestCreateS3LoggingInput/equal-default-prefix-no-partition-date-source
=== PAUSE TestCreateS3LoggingInput/equal-default-prefix-no-partition-date-source
=== RUN   TestForcePathStyleClientSession/path-style-true
=== RUN   TestCreateS3LoggingInput/equal-no-prefix-no-partition-date-source
=== PAUSE TestForcePathStyleClientSession/path-style-true
=== PAUSE TestCreateS3LoggingInput/equal-no-prefix-no-partition-date-source
=== RUN   TestCreateS3LoggingInput/equal-custom-prefix-no-partition-date-source
=== PAUSE TestCreateS3LoggingInput/equal-custom-prefix-no-partition-date-source
=== RUN   TestCreateS3LoggingInput/equal-custom-prefix-custom-partition-date-source
=== RUN   TestDiffersFrom/different_s3_key_values
=== PAUSE TestCreateS3LoggingInput/equal-custom-prefix-custom-partition-date-source
=== PAUSE TestDiffersFrom/different_s3_key_values
=== RUN   TestGCSConfigValuesEqual/equal-encrypt-bool-handling
=== PAUSE TestGCSConfigValuesEqual/equal-encrypt-bool-handling
=== RUN   TestDiffersFrom/different_gcs_prefix_values
=== RUN   TestGCSConfigValuesEqual/equal-general-bool-handling
=== PAUSE TestDiffersFrom/different_gcs_prefix_values
=== PAUSE TestGCSConfigValuesEqual/equal-general-bool-handling
=== RUN   TestDiffersFrom/different_s3_region_values
=== RUN   TestGCSConfigValuesEqual/equal-ignore-gcs-labels
=== PAUSE TestDiffersFrom/different_s3_region_values
=== RUN   TestDiffersFrom/different_gcs_location_values
--- PASS: TestToTerraformInitArgs (0.00s)
=== PAUSE TestDiffersFrom/different_gcs_location_values
--- PASS: TestToTerraformInitArgsNoBackendConfigs (0.00s)
=== RUN   TestDiffersFrom/different_boolean_values_and_boolean_conversion
=== PAUSE TestDiffersFrom/different_boolean_values_and_boolean_conversion
=== RUN   TestDiffersFrom/different_gcs_boolean_values_and_boolean_conversion
=== PAUSE TestDiffersFrom/different_gcs_boolean_values_and_boolean_conversion
=== RUN   TestDiffersFrom/null_values_ignored
=== PAUSE TestDiffersFrom/null_values_ignored
=== RUN   TestDiffersFrom/gcs_null_values_ignored
=== PAUSE TestDiffersFrom/gcs_null_values_ignored
=== PAUSE TestGCSConfigValuesEqual/equal-ignore-gcs-labels
=== CONT  TestNegativePublicAccessResponse/nil-response
--- PASS: TestParseTerraformStateRemoteFull (0.00s)
=== RUN   TestGCSConfigValuesEqual/unequal-wrong-backend
=== CONT  TestNegativePublicAccessResponse/false-response
=== PAUSE TestGCSConfigValuesEqual/unequal-wrong-backend
=== CONT  TestParseTerraformStateLocal
=== CONT  TestNegativePublicAccessResponse/legacy-bucket
=== CONT  TestGetTerraformInitArgs
=== RUN   TestGCSConfigValuesEqual/unequal-values
=== PAUSE TestGCSConfigValuesEqual/unequal-values
=== RUN   TestGetTerraformInitArgs/empty-no-values
=== RUN   TestGCSConfigValuesEqual/unequal-non-empty-config-nil
=== CONT  TestGetAwsSessionConfig/all-values
=== CONT  TestGetAwsSessionConfigWithAssumeRole/all-values
=== CONT  TestGetAwsSessionConfig/no-values
=== CONT  TestGetAwsSessionConfig/extra-values
=== CONT  TestCreateS3LoggingInput/equal-default-prefix-no-partition-date-source
=== CONT  TestCreateS3LoggingInput/equal-no-prefix-no-partition-date-source
=== CONT  TestCreateS3LoggingInput/equal-custom-prefix-no-partition-date-source
=== CONT  TestCreateS3LoggingInput/equal-custom-prefix-custom-partition-date-source
=== RUN   TestConfigValuesEqual/equal-both-empty
=== PAUSE TestConfigValuesEqual/equal-both-empty
=== RUN   TestForcePathStyleClientSession/path-style-false
=== RUN   TestValidateS3Config/no-bucket
=== PAUSE TestForcePathStyleClientSession/path-style-false
--- PASS: TestParseTerraformStateEmpty (0.00s)
=== CONT  TestDiffersFrom/both_empty
=== RUN   TestForcePathStyleClientSession/path-style-non-existent
--- PASS: TestNegativePublicAccessResponse (0.00s)
    --- PASS: TestNegativePublicAccessResponse/nil-response (0.00s)
    --- PASS: TestNegativePublicAccessResponse/false-response (0.00s)
    --- PASS: TestNegativePublicAccessResponse/legacy-bucket (0.00s)
=== PAUSE TestForcePathStyleClientSession/path-style-non-existent
=== CONT  TestParseTerraformStateInvalid
=== RUN   TestValidateS3Config/no-key
=== CONT  TestDiffersFrom/different_gcs_bucket_values
DEBU[0000] Backend  has not changed.                    
=== PAUSE TestGCSConfigValuesEqual/unequal-non-empty-config-nil
=== CONT  TestDiffersFrom/different_s3_bucket_values
=== RUN   TestGCSConfigValuesEqual/unequal-general-bool-handling
=== RUN   TestConfigValuesEqual/equal-empty-and-nil
=== PAUSE TestGCSConfigValuesEqual/unequal-general-bool-handling
=== PAUSE TestConfigValuesEqual/equal-empty-and-nil
=== RUN   TestGCSConfigValuesEqual/equal-null-ignored
DEBU[0000] Changed from map[bucket:foo key:bar region:us-east-1] to map[bucket:different key:bar region:us-east-1] 
=== PAUSE TestGCSConfigValuesEqual/equal-null-ignored
=== RUN   TestConfigValuesEqual/equal-empty-and-nil-backend-config
=== CONT  TestDiffersFrom/identical_GCS_configs
=== PAUSE TestConfigValuesEqual/equal-empty-and-nil-backend-config
=== RUN   TestGCSConfigValuesEqual/terragrunt-only-configs-remain-intact
DEBU[0000] Changed from map[bucket:foo location:europe-west3 prefix:bar project:foo-123456] to map[bucket:different location:europe-west3 prefix:bar project:foo-123456] 
=== RUN   TestConfigValuesEqual/equal-one-key
=== PAUSE TestConfigValuesEqual/equal-one-key
=== PAUSE TestGCSConfigValuesEqual/terragrunt-only-configs-remain-intact
DEBU[0000] Backend gcs has not changed.                 
--- PASS: TestParseTerraformStateLocal (0.00s)
=== CONT  TestDiffersFrom/same_backend_type_value
=== CONT  TestDiffersFrom/different_gcs_prefix_values
=== CONT  TestDiffersFrom/different_s3_key_values
--- PASS: TestGetAwsSessionConfigWithAssumeRole (0.00s)
    --- PASS: TestGetAwsSessionConfigWithAssumeRole/all-values (0.00s)
=== PAUSE TestGetTerraformInitArgs/empty-no-values
DEBU[0000] Backend s3 has not changed.                  
=== CONT  TestDiffersFrom/identical_S3_configs
=== CONT  TestDiffersFrom/gcs_null_values_ignored
=== RUN   TestGetTerraformInitArgs/valid-s3-configuration-keys
DEBU[0000] Backend s3 has not changed.                  
=== RUN   TestConfigValuesEqual/equal-multiple-keys
=== PAUSE TestGetTerraformInitArgs/valid-s3-configuration-keys
=== PAUSE TestConfigValuesEqual/equal-multiple-keys
DEBU[0000] Backend gcs has not changed.                 
=== RUN   TestGetTerraformInitArgs/terragrunt-keys-filtered
=== RUN   TestConfigValuesEqual/equal-encrypt-bool-handling
=== PAUSE TestGetTerraformInitArgs/terragrunt-keys-filtered
DEBU[0000] Changed from map[bucket:foo location:europe-west3 prefix:bar project:foo-123456] to map[bucket:foo location:europe-west3 prefix:different project:foo-123456] 
=== PAUSE TestConfigValuesEqual/equal-encrypt-bool-handling
=== CONT  TestDiffersFrom/different_boolean_values_and_boolean_conversion
DEBU[0000] Changed from map[bucket:foo key:bar region:us-east-1] to map[bucket:foo key:different region:us-east-1] 
=== RUN   TestConfigValuesEqual/equal-general-bool-handling
=== PAUSE TestConfigValuesEqual/equal-general-bool-handling
=== CONT  TestDiffersFrom/different_gcs_boolean_values_and_boolean_conversion
DEBU[0000] Changed from map[something:true] to map[something:%!s(bool=false)] 
=== RUN   TestConfigValuesEqual/equal-ignore-s3-tags
DEBU[0000] Changed from map[something:true] to map[something:%!s(bool=false)] 
=== PAUSE TestConfigValuesEqual/equal-ignore-s3-tags
=== CONT  TestDiffersFrom/different_s3_region_values
=== RUN   TestConfigValuesEqual/equal-ignore-dynamodb-tags
=== PAUSE TestConfigValuesEqual/equal-ignore-dynamodb-tags
=== RUN   TestConfigValuesEqual/equal-ignore-accesslogging-options
=== PAUSE TestConfigValuesEqual/equal-ignore-accesslogging-options
DEBU[0000] Changed from map[bucket:foo key:bar region:us-east-1] to map[bucket:foo key:bar region:different] 
=== RUN   TestConfigValuesEqual/unequal-wrong-backend
=== CONT  TestForcePathStyleClientSession/path-style-non-existent
=== CONT  TestForcePathStyleClientSession/path-style-true
=== CONT  TestDiffersFrom/different_backend_type_values
=== PAUSE TestConfigValuesEqual/unequal-wrong-backend
INFO[0000] Backend type has changed from s3 to atlas    
=== RUN   TestGetTerraformInitArgs/empty-no-values-all-terragrunt-keys-filtered
=== RUN   TestConfigValuesEqual/unequal-values
=== CONT  TestForcePathStyleClientSession/path-style-false
=== PAUSE TestGetTerraformInitArgs/empty-no-values-all-terragrunt-keys-filtered
=== PAUSE TestConfigValuesEqual/unequal-values
=== RUN   TestGetTerraformInitArgs/lock-table-replaced-with-dynamodb-table
=== PAUSE TestGetTerraformInitArgs/lock-table-replaced-with-dynamodb-table
=== RUN   TestGetTerraformInitArgs/dynamodb-table-not-replaced-with-lock-table
=== PAUSE TestGetTerraformInitArgs/dynamodb-table-not-replaced-with-lock-table
=== RUN   TestGetTerraformInitArgs/assume-role
=== PAUSE TestGetTerraformInitArgs/assume-role
=== RUN   TestConfigValuesEqual/unequal-non-empty-config-nil
=== PAUSE TestConfigValuesEqual/unequal-non-empty-config-nil
=== CONT  TestGCSConfigValuesEqual/equal-both-empty
=== CONT  TestDiffersFrom/null_values_ignored
=== CONT  TestGCSConfigValuesEqual/unequal-wrong-backend
DEBU[0000] Backend s3 has not changed.                  
DEBU[0000] Backend type has changed from gcs to wrong   
=== CONT  TestGCSConfigValuesEqual/equal-ignore-gcs-labels
=== RUN   TestConfigValuesEqual/unequal-general-bool-handling
=== CONT  TestGCSConfigValuesEqual/equal-general-bool-handling
=== CONT  TestGCSConfigValuesEqual/equal-encrypt-bool-handling
=== PAUSE TestConfigValuesEqual/unequal-general-bool-handling
=== CONT  TestGCSConfigValuesEqual/equal-multiple-keys
=== CONT  TestGCSConfigValuesEqual/equal-one-key
=== RUN   TestConfigValuesEqual/equal-null-ignored
=== PAUSE TestConfigValuesEqual/equal-null-ignored
=== CONT  TestGCSConfigValuesEqual/unequal-non-empty-config-nil
=== CONT  TestGCSConfigValuesEqual/unequal-general-bool-handling
=== CONT  TestGCSConfigValuesEqual/equal-empty-and-nil
=== CONT  TestGCSConfigValuesEqual/terragrunt-only-configs-remain-intact
=== CONT  TestGCSConfigValuesEqual/equal-null-ignored
=== CONT  TestGetTerraformInitArgs/empty-no-values
--- PASS: TestGetAwsSessionConfig (0.00s)
    --- PASS: TestGetAwsSessionConfig/all-values (0.00s)
    --- PASS: TestGetAwsSessionConfig/no-values (0.00s)
    --- PASS: TestGetAwsSessionConfig/extra-values (0.00s)
DEBU[0000] Backend config changed from map[something:%!s(bool=false)] to map[something:%!s(bool=true)] 
=== CONT  TestGCSConfigValuesEqual/unequal-values
=== CONT  TestGetTerraformInitArgs/empty-no-values-all-terragrunt-keys-filtered
=== CONT  TestGetTerraformInitArgs/terragrunt-keys-filtered
=== CONT  TestGetTerraformInitArgs/valid-s3-configuration-keys
=== CONT  TestGetTerraformInitArgs/lock-table-replaced-with-dynamodb-table
=== CONT  TestGetTerraformInitArgs/dynamodb-table-not-replaced-with-lock-table
--- PASS: TestCreateS3LoggingInput (0.00s)
    --- PASS: TestCreateS3LoggingInput/equal-default-prefix-no-partition-date-source (0.00s)
    --- PASS: TestCreateS3LoggingInput/equal-no-prefix-no-partition-date-source (0.00s)
    --- PASS: TestCreateS3LoggingInput/equal-custom-prefix-no-partition-date-source (0.00s)
    --- PASS: TestCreateS3LoggingInput/equal-custom-prefix-custom-partition-date-source (0.00s)
DEBU[0000] Backend config changed from map[foo:different] to map[foo:bar] 
=== CONT  TestDiffersFrom/different_gcs_location_values
=== CONT  TestGCSConfigValuesEqual/equal-empty-and-nil-backend-config
=== CONT  TestConfigValuesEqual/equal-null-ignored
=== CONT  TestConfigValuesEqual/equal-ignore-accesslogging-options
=== CONT  TestConfigValuesEqual/equal-ignore-dynamodb-tags
=== CONT  TestConfigValuesEqual/equal-both-empty
=== CONT  TestConfigValuesEqual/equal-general-bool-handling
=== CONT  TestGetTerraformInitArgs/assume-role
=== CONT  TestConfigValuesEqual/equal-multiple-keys
=== CONT  TestConfigValuesEqual/equal-one-key
=== CONT  TestConfigValuesEqual/equal-empty-and-nil-backend-config
=== CONT  TestConfigValuesEqual/equal-empty-and-nil
=== CONT  TestConfigValuesEqual/unequal-values
DEBU[0000] Changed from map[bucket:foo location:europe-west3 prefix:bar project:foo-123456] to map[bucket:foo location:different prefix:bar project:foo-123456] 
=== CONT  TestConfigValuesEqual/unequal-general-bool-handling
=== CONT  TestConfigValuesEqual/unequal-wrong-backend
=== CONT  TestConfigValuesEqual/unequal-non-empty-config-nil
=== CONT  TestConfigValuesEqual/equal-encrypt-bool-handling
=== CONT  TestConfigValuesEqual/equal-ignore-s3-tags
--- PASS: TestForcePathStyleClientSession (0.00s)
    --- PASS: TestForcePathStyleClientSession/path-style-false (0.00s)
    --- PASS: TestForcePathStyleClientSession/path-style-true (0.00s)
    --- PASS: TestForcePathStyleClientSession/path-style-non-existent (0.00s)
--- PASS: TestParseTerraformStateInvalid (0.00s)
--- PASS: TestValidateS3Config (0.00s)
    --- PASS: TestValidateS3Config/no-region (0.00s)
    --- PASS: TestValidateS3Config/no-bucket (0.00s)
    --- PASS: TestValidateS3Config/no-key (0.00s)
--- PASS: TestGCSConfigValuesEqual (0.00s)
    --- PASS: TestGCSConfigValuesEqual/equal-both-empty (0.00s)
    --- PASS: TestGCSConfigValuesEqual/unequal-wrong-backend (0.00s)
    --- PASS: TestGCSConfigValuesEqual/equal-ignore-gcs-labels (0.00s)
    --- PASS: TestGCSConfigValuesEqual/equal-general-bool-handling (0.00s)
    --- PASS: TestGCSConfigValuesEqual/equal-encrypt-bool-handling (0.00s)
    --- PASS: TestGCSConfigValuesEqual/equal-one-key (0.00s)
    --- PASS: TestGCSConfigValuesEqual/equal-multiple-keys (0.00s)
    --- PASS: TestGCSConfigValuesEqual/unequal-non-empty-config-nil (0.00s)
    --- PASS: TestGCSConfigValuesEqual/equal-empty-and-nil (0.00s)
    --- PASS: TestGCSConfigValuesEqual/terragrunt-only-configs-remain-intact (0.00s)
    --- PASS: TestGCSConfigValuesEqual/equal-null-ignored (0.00s)
    --- PASS: TestGCSConfigValuesEqual/unequal-general-bool-handling (0.00s)
    --- PASS: TestGCSConfigValuesEqual/equal-empty-and-nil-backend-config (0.00s)
    --- PASS: TestGCSConfigValuesEqual/unequal-values (0.00s)
DEBU[0000] Backend type has changed from s3 to wrong    
DEBU[0000] Backend config changed from map[foo:different] to map[foo:bar] 
--- PASS: TestDiffersFrom (0.00s)
    --- PASS: TestDiffersFrom/both_empty (0.00s)
    --- PASS: TestDiffersFrom/different_s3_bucket_values (0.00s)
    --- PASS: TestDiffersFrom/different_gcs_bucket_values (0.00s)
    --- PASS: TestDiffersFrom/identical_GCS_configs (0.00s)
    --- PASS: TestDiffersFrom/same_backend_type_value (0.00s)
    --- PASS: TestDiffersFrom/identical_S3_configs (0.00s)
    --- PASS: TestDiffersFrom/gcs_null_values_ignored (0.00s)
    --- PASS: TestDiffersFrom/different_gcs_prefix_values (0.00s)
    --- PASS: TestDiffersFrom/different_s3_key_values (0.00s)
    --- PASS: TestDiffersFrom/different_boolean_values_and_boolean_conversion (0.00s)
    --- PASS: TestDiffersFrom/different_gcs_boolean_values_and_boolean_conversion (0.00s)
    --- PASS: TestDiffersFrom/different_s3_region_values (0.00s)
    --- PASS: TestDiffersFrom/different_backend_type_values (0.00s)
    --- PASS: TestDiffersFrom/null_values_ignored (0.00s)
    --- PASS: TestDiffersFrom/different_gcs_location_values (0.00s)
DEBU[0000] Backend config changed from map[something:%!s(bool=false)] to map[something:%!s(bool=true)] 
--- PASS: TestConfigValuesEqual (0.00s)
    --- PASS: TestConfigValuesEqual/equal-null-ignored (0.00s)
    --- PASS: TestConfigValuesEqual/equal-both-empty (0.00s)
    --- PASS: TestConfigValuesEqual/equal-ignore-dynamodb-tags (0.00s)
    --- PASS: TestConfigValuesEqual/equal-ignore-accesslogging-options (0.00s)
    --- PASS: TestConfigValuesEqual/equal-general-bool-handling (0.00s)
    --- PASS: TestConfigValuesEqual/equal-multiple-keys (0.00s)
    --- PASS: TestConfigValuesEqual/equal-one-key (0.00s)
    --- PASS: TestConfigValuesEqual/equal-empty-and-nil-backend-config (0.00s)
    --- PASS: TestConfigValuesEqual/equal-empty-and-nil (0.00s)
    --- PASS: TestConfigValuesEqual/unequal-non-empty-config-nil (0.00s)
    --- PASS: TestConfigValuesEqual/equal-encrypt-bool-handling (0.00s)
    --- PASS: TestConfigValuesEqual/equal-ignore-s3-tags (0.00s)
    --- PASS: TestConfigValuesEqual/unequal-wrong-backend (0.00s)
    --- PASS: TestConfigValuesEqual/unequal-values (0.00s)
    --- PASS: TestConfigValuesEqual/unequal-general-bool-handling (0.00s)
--- PASS: TestGetTerraformInitArgs (0.00s)
    --- PASS: TestGetTerraformInitArgs/empty-no-values (0.00s)
    --- PASS: TestGetTerraformInitArgs/empty-no-values-all-terragrunt-keys-filtered (0.00s)
    --- PASS: TestGetTerraformInitArgs/terragrunt-keys-filtered (0.00s)
    --- PASS: TestGetTerraformInitArgs/valid-s3-configuration-keys (0.00s)
    --- PASS: TestGetTerraformInitArgs/dynamodb-table-not-replaced-with-lock-table (0.00s)
    --- PASS: TestGetTerraformInitArgs/assume-role (0.00s)
    --- PASS: TestGetTerraformInitArgs/lock-table-replaced-with-dynamodb-table (0.00s)
PASS
ok      github.com/gruntwork-io/terragrunt/remote       0.016s

yhakbar

Re-tested and it passed. Thank you so much, @findmyname666 !

Great work. I really appreciate the effort and time you put into testing this.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [gruntwork-io/terragrunt](https://togithub.com/gruntwork-io/terragrunt) | patch | `v0.66.3` -> `v0.66.5` | | [gruntwork-io/terragrunt](https://togithub.com/gruntwork-io/terragrunt) | patch | `0.66.3` -> `0.66.5` | --- ### Release Notes <details> <summary>gruntwork-io/terragrunt (gruntwork-io/terragrunt)</summary> ### [`v0.66.5`](https://togithub.com/gruntwork-io/terragrunt/releases/tag/v0.66.5) [Compare Source](https://togithub.com/gruntwork-io/terragrunt/compare/v0.66.4...v0.66.5) #### What's Changed - chore: Adding `bugs` Lint Preset by [@yhakbar](https://togithub.com/yhakbar) in [https://github.com/gruntwork-io/terragrunt/pull/3334](https://togithub.com/gruntwork-io/terragrunt/pull/3334) - chore: Adding `performance` Lint Preset by [@yhakbar](https://togithub.com/yhakbar) in [https://github.com/gruntwork-io/terragrunt/pull/3336](https://togithub.com/gruntwork-io/terragrunt/pull/3336) **Full Changelog**: gruntwork-io/terragrunt@v0.66.4...v0.66.5 ### [`v0.66.4`](https://togithub.com/gruntwork-io/terragrunt/releases/tag/v0.66.4) [Compare Source](https://togithub.com/gruntwork-io/terragrunt/compare/v0.66.3...v0.66.4) #### What's Changed - feat: Add stale issue workflow by [@yhakbar](https://togithub.com/yhakbar) in [https://github.com/gruntwork-io/terragrunt/pull/3329](https://togithub.com/gruntwork-io/terragrunt/pull/3329) - feat: Add configuration options for AWS S3 server access logging by [@findmyname666](https://togithub.com/findmyname666) in [https://github.com/gruntwork-io/terragrunt/pull/3006](https://togithub.com/gruntwork-io/terragrunt/pull/3006) - fix: Fixing command not found error by [@yhakbar](https://togithub.com/yhakbar) in [https://github.com/gruntwork-io/terragrunt/pull/3330](https://togithub.com/gruntwork-io/terragrunt/pull/3330) - fix: Fixing stale action by [@yhakbar](https://togithub.com/yhakbar) in [https://github.com/gruntwork-io/terragrunt/pull/3332](https://togithub.com/gruntwork-io/terragrunt/pull/3332) - fix: Fix CICD tests for mocks by [@denis256](https://togithub.com/denis256) in [https://github.com/gruntwork-io/terragrunt/pull/3335](https://togithub.com/gruntwork-io/terragrunt/pull/3335) - chore: Bumping `golangci-lint` to `v1.59.1` by [@yhakbar](https://togithub.com/yhakbar) in [https://github.com/gruntwork-io/terragrunt/pull/3333](https://togithub.com/gruntwork-io/terragrunt/pull/3333) - chore: Hiding Mocks Tests by [@yhakbar](https://togithub.com/yhakbar) in [https://github.com/gruntwork-io/terragrunt/pull/3331](https://togithub.com/gruntwork-io/terragrunt/pull/3331) #### New Contributors - [@findmyname666](https://togithub.com/findmyname666) made their first contribution in [https://github.com/gruntwork-io/terragrunt/pull/3006](https://togithub.com/gruntwork-io/terragrunt/pull/3006) **Full Changelog**: gruntwork-io/terragrunt@v0.66.3...v0.66.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/akrantz01/homelab).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

findmyname666 requested a review from denis256 as a code owner March 18, 2024 08:01

findmyname666 mentioned this pull request Mar 18, 2024

Expose additional configuration options for AWS S3 server access logging #3003

Closed

findmyname666 changed the title ~~Expose additional configuration options for AWS S3 server access logging~~ Add configuration options for AWS S3 server access logging Mar 18, 2024

findmyname666 mentioned this pull request Mar 18, 2024

Add configuration options for AWS S3 server access logging #3004

Closed

4 tasks

denis256 reviewed Mar 19, 2024

View reviewed changes

findmyname666 requested a review from denis256 March 22, 2024 11:23

findmyname666 force-pushed the feature/s3-new-options-access-logging-3003 branch from 675daef to e4b533b Compare April 5, 2024 19:11

findmyname666 changed the base branch from master to pull-request-2878 April 5, 2024 19:19

findmyname666 changed the base branch from pull-request-2878 to master April 5, 2024 19:19

adrianeib added 2 commits August 9, 2024 15:57

Add configuration options for AWS S3 server access logging

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

b85adf5

add tests

Loading
Loading status checks…

d6f82a1

findmyname666 force-pushed the feature/s3-new-options-access-logging-3003 branch from e4b533b to d6f82a1 Compare August 9, 2024 14:00

findmyname666 requested review from levkohimins and yhakbar as code owners August 9, 2024 14:00

yhakbar approved these changes Aug 9, 2024

View reviewed changes

yhakbar merged commit e79d9f4 into gruntwork-io:master Aug 9, 2024
4 checks passed

BrewTestBot mentioned this pull request Aug 12, 2024

terragrunt 0.66.4 Homebrew/homebrew-core#180930

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add configuration options for AWS S3 server access logging #3006

Add configuration options for AWS S3 server access logging #3006

findmyname666 commented Mar 18, 2024 •

edited

Loading

denis256 Mar 19, 2024

findmyname666 Mar 22, 2024 •

edited

Loading

findmyname666 Apr 3, 2024

findmyname666 Apr 10, 2024

yhakbar commented Aug 5, 2024

findmyname666 commented Aug 7, 2024

sonarqubecloud bot commented Aug 9, 2024

findmyname666 commented Aug 9, 2024

yhakbar left a comment

Add configuration options for AWS S3 server access logging #3006

Add configuration options for AWS S3 server access logging #3006

Conversation

findmyname666 commented Mar 18, 2024 • edited Loading

Description

TODOs

Release Notes (draft)

Migration Guide

denis256 Mar 19, 2024

Choose a reason for hiding this comment

findmyname666 Mar 22, 2024 • edited Loading

Choose a reason for hiding this comment

findmyname666 Apr 3, 2024

Choose a reason for hiding this comment

findmyname666 Apr 10, 2024

Choose a reason for hiding this comment

yhakbar commented Aug 5, 2024

findmyname666 commented Aug 7, 2024

sonarqubecloud bot commented Aug 9, 2024

Quality Gate passed

findmyname666 commented Aug 9, 2024

yhakbar left a comment

Choose a reason for hiding this comment

findmyname666 commented Mar 18, 2024 •

edited

Loading

findmyname666 Mar 22, 2024 •

edited

Loading