This repository was archived by the owner on May 24, 2024. It is now read-only.
Refactoring Action #7
Merged
+233
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhakbar
force-pushed
the
chore/refactoring-action
branch
from
a813f0d to
28a0789
Compare
oredavids
previously approved these changes
May 16, 2024
scripts/calculate-table.sh
Outdated
|
|
||
| set -euo pipefail | ||
|
|
||
| # I would normally do this, but it's not worth risking for now. |
Resonance1584
previously approved these changes
May 16, 2024
Co-authored-by: Oreoluwa Agunbiade <21035422+oredavids@users.noreply.github.com>
Resonance1584
approved these changes
May 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring action by moving the bash code in the
runsteps to scripts.I think this should make it easier to move to Go later.
This incidentally squashed some bugs, and improved syntax highlighting.
I've tested in a demo org, and can share that internally. I also think this refactor might require some live review, due to the number of lines adjusted.