[Build] Minimum version of MSVC is now 2022 #37687
Closed
+9
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veblush
added
platform/Windows
area/build
release notes: yes
grpc-checks
bot
added
bloat/none
per-call-memory/decrease
per-channel-memory/neutral
labels
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/decrease
labels
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/neutral
labels
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/decrease
labels
yashykt
approved these changes
Sep 27, 2024
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/neutral
labels
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/decrease
labels
davidben
added a commit
to google/boringssl
that referenced
this pull request
Oct 8, 2024
Per https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md, we can require VS2022 or later. Looking at notable downstreams, Envoy doesn't support Windows at all anymore, and gRPC raised their minimum in grpc/grpc#37687 Update-Note: On Windows, MSVC 2022 or later is now allowed. This change will make the vs2022 configs on CI redundant with the default ones. I'll remove the redundant ones after this lands. Change-Id: Ib740e091271c94e0ef8999e61a31a8e3df63f349 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/71830 Auto-Submit: David Benjamin <davidben@google.com> Commit-Queue: David Benjamin <davidben@google.com> Commit-Queue: Bob Beck <bbe@google.com> Reviewed-by: Bob Beck <bbe@google.com>
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Nov 25, 2024
Per https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md, we can require msvc 2022 or later. Closes grpc#37687 COPYBARA_INTEGRATE_REVIEW=grpc#37687 from veblush:msvc2022 32e35ec PiperOrigin-RevId: 680682655
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md, we can require msvc 2022 or later.