Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[grpc][Gpr_To_Absl_Logging] Changing definition of GPR_ASSERT macro #36656

Closed
wants to merge 7 commits into from
Closed

[grpc][Gpr_To_Absl_Logging] Changing definition of GPR_ASSERT macro #36656

wants to merge 7 commits into from

Conversation

tanvi-jagtap
Copy link
Contributor

@tanvi-jagtap tanvi-jagtap commented May 17, 2024 •
edited

[grpc][Gpr_To_Absl_Logging] Remove gpr_assertion_failed

  1. Remove gpr_assertion_failed
  2. Using LOG(FATAL) instead.
  3. Defining GPR_ASSERT as CHECK

@tanvi-jagtap tanvi-jagtap added the release notes: no Indicates if PR should not be in release notes label May 17, 2024
@tanvi-jagtap tanvi-jagtap marked this pull request as ready for review May 17, 2024 10:49
@tanvi-jagtap tanvi-jagtap deleted the gpr_assert_macro_tjagtap branch June 6, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bloat/none lang/c++ lang/core lang/ruby per-call-memory/neutral per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tanvi-jagtap