-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[logging] Centralize configuration for trace flags #36576
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grpc-checks
bot
added
bloat/low
per-call-memory/neutral
per-channel-memory/neutral
labels
May 10, 2024
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/neutral
labels
May 10, 2024
drfloob
requested review from
ctiller and
markdroth
and removed request for
markdroth
May 10, 2024 06:56
grpc-checks
bot
added
bloat/medium
per-call-memory/decrease
per-call-memory/increase
and removed
bloat/low
per-call-memory/increase
per-call-memory/decrease
labels
May 10, 2024
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/increase
labels
May 10, 2024
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/neutral
labels
May 29, 2024
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/decrease
labels
Jun 4, 2024
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/neutral
labels
Jun 5, 2024
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/increase
labels
Jun 6, 2024
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/neutral
labels
Jun 6, 2024
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/decrease
labels
Jun 6, 2024
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/increase
labels
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bloat/medium
lang/c++
lang/core
per-call-memory/neutral
per-channel-memory/neutral
release notes: no
Indicates if PR should not be in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All TraceFlags are now configured in
src/core/lib/debug/trace_flags.yaml
. The format is:To regenerate the trace flag source code, run
tools/codegen/core/gen_trace_flags.py
(requires mako). This script is also run when sanity checking.This PR also adds two new features:
Glob-based flag configuration
Trace flag configuration now supports
?
(single wildcard character) and*
(one or more wildcard characters). For example, usingGRPC_TRACE='event_engine*'
will enable all flags that match that glob. It expands to:A cleaner trace-logging macro in abseil logging format
If your goal is only to add log statements when the
fault_injection_filter
trace flag is enabled, you can use the macro:When the trace flag is enabled, the the log will show something like this:
Note: just like with the gpr_log to abseil logging conversion, the pre-existing trace logging usages can be replaced with the new tracing macro across multiple PRs.