[OTel C++] Add API to set channel scope filter #36189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashykt
added
lang/c++
release notes: yes
grpc-checks
bot
added
bloat/none
per-call-memory/neutral
per-channel-memory/neutral
labels
markdroth
reviewed
Mar 28, 2024
yijiem
reviewed
Mar 28, 2024
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/neutral
labels
grpc-checks
bot
added
bloat/low
per-call-memory/decrease
and removed
bloat/none
per-call-memory/increase
labels
markdroth
approved these changes
Apr 2, 2024
src/cpp/ext/otel/otel_plugin.h
Outdated
| const ChannelScope& scope) | ||
| ClientScopeConfig( | ||
| const OpenTelemetryPlugin* otel_plugin, | ||
| const grpc_core::experimental::StatsPluginChannelScope& scope) |
There was a problem hiding this comment.
This should probably refer to this type as OpenTelemetryPluginBuilder::ChannelScope, for consistency with the rest of this code.
src/cpp/ext/otel/otel_plugin.h
Outdated
| @@ -337,7 +338,8 @@ class OpenTelemetryPlugin : public grpc_core::StatsPlugin { | |||
|
|
|||
| // StatsPlugin: | |||
| std::pair<bool, std::shared_ptr<grpc_core::StatsPlugin::ScopeConfig>> | |||
| IsEnabledForChannel(const ChannelScope& scope) const override; | |||
| IsEnabledForChannel(const grpc_core::experimental::StatsPluginChannelScope& | |||
There was a problem hiding this comment.
Same here: This should probably refer to this type as OpenTelemetryPluginBuilder::ChannelScope, for consistency with the rest of this code.
| target, args.GetOwnedString(GRPC_ARG_DEFAULT_AUTHORITY).value_or("")); | ||
| experimental::StatsPluginChannelScope scope( | ||
| target, args.GetOwnedString(GRPC_ARG_DEFAULT_AUTHORITY) | ||
| .value_or(CoreConfiguration::Get() |
There was a problem hiding this comment.
I've done some digging to remind myself of the flow here (details originally came from #14615 (comment)), and I've convinced myself that this approach makes sense. There's some more cleanup that will be needed here, but I'll take care of that in the v3 stack.
grpc-checks
bot
added
bloat/none
per-call-memory/neutral
and removed
bloat/low
per-call-memory/decrease
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also addressing a TODO from previous PRs where
authorityis not being populated in theChannelScope.