[Python O11y] Change public interface #36094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuanWang-Amos
added
the
release notes: yes
gnossen
reviewed
Mar 12, 2024
src/python/grpcio_observability/grpc_observability/_open_telemetry_exporter.py
Outdated
Show resolved
Hide resolved
src/python/grpcio_observability/grpc_observability/_open_telemetry_observability.py
Outdated
Show resolved
Hide resolved
XuanWang-Amos
force-pushed
the
otel_public_api
branch
from
f935cd4
to
ec22066
Compare
gnossen
approved these changes
Mar 12, 2024
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
Mar 18, 2024
Address comments from design review meeting, mainly: * Use `OpenTelemetryPlugin` as public API. * Use keyword args to build plugin. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#36094 PiperOrigin-RevId: 615807264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address comments from design review meeting, mainly:
OpenTelemetryPluginas public API.