[OTel C++] Add CMake build support #36063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
per-call-memory/increase
and removed
per-call-memory/neutral
labels
grpc-checks
bot
added
bloat/none
per-call-memory/neutral
and removed
per-call-memory/increase
labels
veblush
approved these changes
Mar 8, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
Earlier, the tests just had bazel support. With CMake support added in #36063, we can also add CI CMake support for the tests. A major benefit of this is that we also get coverage for the various platforms that we test from our portability test suite. Closes #36087 COPYBARA_INTEGRATE_REVIEW=#36087 from yashykt:OTelCISupport b28fbe0 PiperOrigin-RevId: 615543685
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
Mar 18, 2024
Earlier, the tests just had bazel support. With CMake support added in grpc#36063, we can also add CI CMake support for the tests. A major benefit of this is that we also get coverage for the various platforms that we test from our portability test suite. Closes grpc#36087 COPYBARA_INTEGRATE_REVIEW=grpc#36087 from yashykt:OTelCISupport b28fbe0 PiperOrigin-RevId: 615543685
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes -
grpcpp_otel_plugin. Currently, we are only supporting thefind_package CONFIGmethod for depending onopentelemetry-cpp.grpcpp_otel_pluginis an extension of gRPC, it will not be built by default. To enable building of this target, a new CMake optiongRPC_BUILD_GRPCPP_OTEL_PLUGINis being added.CMakeLists.txtto the otel example.The
otel_plugin_testcan also be built through cmake but, for the CI to work, there are some additional changes. Those will be made in an upcoming PR.