-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[csharp] Fix csharp doc comments #36000
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grpc-checks
bot
added
bloat/none
per-call-memory/decrease
per-channel-memory/neutral
labels
Feb 26, 2024
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Feb 26, 2024
Fix C# document comments when there is an extra `/` at the start of a comment line. See grpc/grpc#35905 Related to grpc/grpc#36000 which also fixes the issue in the gRPC C# plugin Closes #15955 COPYBARA_INTEGRATE_REVIEW=#15955 from tonydnewell:csharp-comment-fix d80e09a FUTURE_COPYBARA_INTEGRATE_REVIEW=#15955 from tonydnewell:csharp-comment-fix d80e09a PiperOrigin-RevId: 610423152
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Feb 27, 2024
Fix C# document comments when there is an extra `/` at the start of a comment line. See grpc/grpc#35905 Related to grpc/grpc#36000 which also fixes the issue in the gRPC C# plugin Closes #15955 COPYBARA_INTEGRATE_REVIEW=#15955 from tonydnewell:csharp-comment-fix d80e09a FUTURE_COPYBARA_INTEGRATE_REVIEW=#15955 from tonydnewell:csharp-comment-fix d80e09a PiperOrigin-RevId: 610423152
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Feb 27, 2024
Fix C# document comments when there is an extra `/` at the start of a comment line. See grpc/grpc#35905 Related to grpc/grpc#36000 which also fixes the issue in the gRPC C# plugin Closes #15955 COPYBARA_INTEGRATE_REVIEW=#15955 from tonydnewell:csharp-comment-fix d80e09a PiperOrigin-RevId: 610784971
apolcyn
approved these changes
Feb 28, 2024
@tonydnewell clang format complains:
|
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/decrease
labels
Feb 29, 2024
apolcyn
added
release notes: yes
Indicates if PR needs to be in release notes
kokoro:force-run
labels
Mar 6, 2024
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/increase
labels
Mar 6, 2024
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/neutral
labels
Mar 7, 2024
apolcyn
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bloat/none
lang/C#
per-call-memory/increase
per-channel-memory/neutral
release notes: yes
Indicates if PR needs to be in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix C# document comments when there is an extra / at the start of a comment line.
See #35905
Related to protocolbuffers/protobuf#15955 which also fixes the issue in protoc compiler.