Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[surface] Add an API to inject connected endpoints into servers #35957

Closed
wants to merge 160 commits into from

Conversation

drfloob
Copy link
Member

@drfloob drfloob commented Feb 21, 2024

No description provided.

@grpc-checks grpc-checks bot removed the bloat/low label Mar 8, 2024
copybara-service bot pushed a commit that referenced this pull request Apr 2, 2024
…insecure creds (#36176)

Forked from #35957

This PR refactors the credentials types to remove Secure and Insecure Channel and Call credentials types. We standardize on a `c_creds()` accessor method for all credentials types, which can now be treated uniformly. This notably removes special-case handling of insecure credentials.

The special code-paths for insecure creds are no longer necessary in the wake of #25586.

Closes #36176

COPYBARA_INTEGRATE_REVIEW=#36176 from drfloob:fork/35957/creds-API fd64d59
PiperOrigin-RevId: 621008166
Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Feel free to merge after addressing the remaining nits.

include/grpcpp/server_builder.h Outdated Show resolved Hide resolved
src/core/ext/transport/chttp2/server/chttp2_server.cc Outdated Show resolved Hide resolved
src/core/ext/transport/chttp2/server/chttp2_server.cc Outdated Show resolved Hide resolved
Copy link
Member Author

@drfloob drfloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mark!

src/core/ext/transport/chttp2/server/chttp2_server.cc Outdated Show resolved Hide resolved
src/core/ext/transport/chttp2/server/chttp2_server.cc Outdated Show resolved Hide resolved
include/grpcpp/server_builder.h Outdated Show resolved Hide resolved
@copybara-service copybara-service bot closed this in 7c57fb7 Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants