-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[surface] Add an API to inject connected endpoints into servers #35957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drfloob
added
the
release notes: yes
Indicates if PR needs to be in release notes
label
Feb 21, 2024
grpc-checks
bot
added
bloat/low
per-call-memory/decrease
per-channel-memory/neutral
and removed
bloat/medium
labels
Feb 21, 2024
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/decrease
labels
Feb 21, 2024
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/increase
labels
Feb 22, 2024
This reverts commit 8d81fd4.
grpc-checks
bot
added
per-call-memory/decrease
per-call-memory/increase
and removed
per-call-memory/neutral
per-call-memory/decrease
labels
Mar 29, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
…insecure creds (#36176) Forked from #35957 This PR refactors the credentials types to remove Secure and Insecure Channel and Call credentials types. We standardize on a `c_creds()` accessor method for all credentials types, which can now be treated uniformly. This notably removes special-case handling of insecure credentials. The special code-paths for insecure creds are no longer necessary in the wake of #25586. Closes #36176 COPYBARA_INTEGRATE_REVIEW=#36176 from drfloob:fork/35957/creds-API fd64d59 PiperOrigin-RevId: 621008166
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/increase
labels
Apr 4, 2024
markdroth
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Feel free to merge after addressing the remaining nits.
drfloob
commented
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mark!
markdroth
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bloat/medium
lang/c++
lang/core
lang/ruby
per-call-memory/neutral
per-channel-memory/neutral
release notes: yes
Indicates if PR needs to be in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.